Page MenuHomePhabricator

Deprecated Article::insertNewArticle still used in core
Closed, ResolvedPublic

Description

Deprecated Article::insertNewArticle still used in core (also in some svn extensions).

docs/hooks.txt:saved, that is before insertNewArticle() is called
includes/Title.php: * - This is called from Article::insertNewArticle() to allow
includes/EditPage.php: $this->mArticle->insertNewArticle( $this->textbox1, $this->summary,
includes/Article.php: function insertNewArticle( $text, $summary, $isminor, $watchthis, $suppressRC=false, $comment=false, $bot=false ) {

maintenance/parserTests.inc: $art->insertNewArticle($text, '', false, false );
maintenance/addwiki.php: $wgArticle->insertNewArticle( <<<EOT

extensions/YouTubeAuthSub/YouTubeAuthSub_body.php: $a->insertNewArticle($content,
extensions/SpamDiffTool/SpamDiffTool.php: $a->insertNewArticle($text, wfMsg('spamdifftool_summary'), false, $watch);
extensions/wikiforum/wikiforum.php: $article->insertNewArticle($wgRequest->getVal('threadDescription', ''), WF_Msg('ThreadNew'), false, false);
extensions/Postcomment/SpecialPostcomment.php: $article->insertNewArticle($text, "", true, $watch, false, false, true);
extensions/TalkHere/TalkHereArticle.php: if ($name == 'insertNewArticle') {


Version: unspecified
Severity: normal

Details

Reference
bz18891

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:44 PM
bzimport set Reference to bz18891.
bzimport added a subscriber: Unknown Object (MLST).

happy.melon.wiki wrote:

Seems this is actually only *really* used in core in EditPage.php, plus extensions.

ayg wrote:

I didn't undeprecate it, I just removed the wfDeprecated() so it doesn't spam us until it's removed. When it's removed, wfDeprecated() can be re-added.

Search results haven't really changed, so the reported issue still exists.

Reverted r68606 and removed wfDeprecated(). There's no warning to worry about now so I'll mark this invalid.

Changing resolution to FIXED, the last call in EditPage.php was modified in r80402.