Author: phil
Description:
Update jogg's handling of incomplete packets
This patch updates the pagein function to match the current libogg implemnation. This fixes a bug where Cortado would die when a Theora stream begins with an incomplete packet, and tries to process it as a header.
I have been testing this patch on my website, and so far so good.
Version: unspecified
Severity: major
URL: http://webcam.firestorm.cx/
See Also:
https://trac.xiph.org/ticket/1565
Attached:
sumanah wrote:
Philip, thanks for the patch, and my apologies that it has taken so long to review!
Is it still necessary?
If so, it would be great if you could submit it directly into our source control system: https://www.mediawiki.org/wiki/Git/Tutorial
TimedMediaHandler was deployed at the beginning of November 2012, see
https://www.mediawiki.org/wiki/TimedMediaHandler and http://blog.wikimedia.org/2012/11/08/introducing-wikipedias-new-html5-video-player/ for more information.
It is based on HTML5 and supports closed captions, timed text, WebM, etc.
This bug report was reported about "Cortado". With TimedMediaHandler being in place, Cortado is now ONLY used as a fallback for web browsers that do not support any of the video codecs we offer but have Java installed. This currently is Apple Safari without XiphQt installed, or Microsoft Internet Explorer with Java applet installed.
Please add a comment here in case that you still face the problem described (now with Cortado inside of TimedMediaHandler) if using one of the browsers mentioned above. In that case, this report should be moved to product="MediaWiki extensions" and component="TimedMediaHandler" in this bug tracker.
Issues that also happen with Cortado without TimedMediaHandler should be reported to https://trac.xiph.org/ instead.