| Jidanni | |
| Jun 2 2009, 6:48 PM |
| F5792: RC2.txt | |
| Nov 21 2014, 10:40 PM |
rebuildrecentchanges.php forgets to purge RSS and Atom feeds, meaning feed users will still get old drivel. This patch purges the feeds, and also fixes docs/memcached.txt. Actually I don't purge the
Version: 1.16.x
Severity: normal
attachment rebuildrecentchangesFEED.txt ignored as obsolete
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Feature | None | T5646 RSS, Atom, XML syndication feeds (tracking) | ||
| Resolved | None | T21055 rebuildrecentchanges.php must purge RSS and Atom feeds | |||
| Resolved | None | T21391 The feed on Special:RecentChanges is cached in random language |
Actually I don't purge the feeds, as I don't know how to easily match
the many $wgDBname:rcfeed:*:*:*: combinations that might be present in
the cache. However I found that just deleting the timestamps works good
enough for now.
You shouldn't be adding to the key manually by appending :keypart, etc. Pass all the parts of the key to wfMemcKey() in an array.
Instead of:
wfMemcKey('rcfeed').":{$feed}:timestamp"
Try:
wfMemcKey( array( 'rcfeed', $feed, 'timestamp' )
Not only does using
$messageMemc->delete(wfMemcKey( array( 'rcfeed', $feed, 'timestamp' )));
not help in deleting
keyname: radioscanningtw:rcfeed:atom:50::
keyname: radioscanningtw:rcfeed:rss:2::
keyname: radioscanningtw:rcfeed:rss:4::
but it doesn't even delete
keyname: radioscanningtw:rcfeed:rss:timestamp
So, sorry.
What I need is a utility function, like UNIX rm -r, which will expand
to all rcfeed:* matches, no matter how many trailing colons. That way
I need not leave any of these now useless strings wastefully behind
there in the database, for months too in the case of quiet wikis. By
the way
public static function checkPurge( $timekey, $key )
could make use of such a function too, as it also leaves some things
wastefully behind. Such a function should reside in the same file the
rest of those mem* functions do.