Page MenuHomePhabricator

Maintenance script cleanup
Closed, ResolvedPublic

Description

Putting this in because it's long been a pipe dream of mine...

It would be nice if we eventually got around to cleaning up the maintenance scripts. Some of them don't even work anymore, some are obsolete and should be clearly marked as such.

It would be nice to migrate them all to a unified format (maybe an abstract Maintenance class that various scripts can implement.


Version: unspecified
Severity: enhancement
URL: http://www.mediawiki.org/wiki/User:^demon/maintenance-work

Details

Reference
bz19133

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:38 PM
bzimport set Reference to bz19133.

List of the ultimate goals:

  1. Remove/archive and scripts that aren't needed
  2. Cleanup scripts to use a unified system. Implementation idea: abstract Maintenance class with an execute() method for children to implement. Unify global parameters such as --quiet, --help, and the db ones (cf bug 16322)
  3. Clean up database usage in the scripts. Right now we have a hodgepodge of creating our own adapter (see X and Y) and properly using wfGetDB(). We should unify this to the latter.

I have the basic start of a patch for #2, just missing a few features. Ports all of the commandLine.inc code to it, plus some extra goodies. Will attach when ready.

X and Y were supposed to be backup.inc, rebuildall.php, convertLinks.inc, etc etc.

See r51675-77 for the start of this.

Assigning to me, should've been that way already. Also adding URL to page on MW.org. I encourage people to read and comment on this, as I would like a wide range of input.

Merged current work in r52336. Still needs work, but the framework should be in place to keep going.

Created attachment 6369
Patch against trunk, r53514

Doesn't complete everything, but implements the vast majority of the work. Merges cleanly against r53514. commandLine.inc is _untouched_ at this point, so everything relying on it should still work 100%.

attachment maintenance-work.patch ignored as obsolete

Created attachment 6370
Updated patch

Minor tweaks, against r53521

Attached:

Can we consider this FIXED with the merge of the maintenance work branch or are there still open issues?

Hmmm, I guess we could. This bug was a tracker for general cleanup & the merge. Most of the remaining blockers I didn't add anyway.

Closing this out. We've merged and cleaned up most of the issues. The few straggling blockers can be cleaned up without this tracker :)