If createAndPromote is fed a bad password, the account is created anyway. Should roll back the creation if we can't make a valid PW.
Version: 1.16.x
Severity: normal
Description
Description
Details
Details
- Reference
- bz19157
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • demon | T21133 Maintenance script cleanup | |||
| Resolved | None | T21157 createAndPromote error on bad password |
Event Timeline
Comment Actions
Adds password checking; also makes the other messages a little more informative
Attached:
Comment Actions
As it is, the script is going to report back with "password too short" even if the password was rejected for another reason. (Fixing this will probably require reworking User::setPassword() and User::isValidPassword).
Comment Actions
overlordq wrote:
patch to isValidPassword and setPassword
Horrible patch to separate too short passwords from invalid passwords. Unfortunately requires a message change.
Attached:
Comment Actions
Copying my notes from Code Review on r52494:
Eww... this is a really ugly calling convention.
If the function is named 'isSomething', it needs to return a boolean otherwise you're just asking for trouble. An optional outparam for returning a message key would be much less annoying in this context.
Comment Actions
This has been fixed for awhile now. User.php was cleaned up, and my original complaint about creating users with bad passwords has also been fixed for quite some time.