| Jidanni | |
| Jun 14 2009, 7:40 AM |
| F5848: message-fix.patch | |
| Nov 21 2014, 10:42 PM |
In specials/SpecialSpecialpages.php,
'Userlogin' => array( 'SpecialPage', 'Userlogin' ),
'CreateAccount' => array( 'SpecialRedirectToSpecial', ...
Well, just as is already solved in SkinTemplate.php:
$loginlink = $wgUser->isAllowed( 'createaccount' )
? 'nav-login-createaccount'
: 'login';
please first check if they really can create an account, before
advertising to do so.
Version: 1.16.x
Severity: enhancement
happy.melon.wiki wrote:
Could you clarify the issue here? There's a check in SkinTemplate to switch between a "login/createaccount" link and a simple "login" link if the user can't create an account; I assume that the bug is that this check is not done elsewhere; but where, exactly?
matthew.britton wrote:
(In reply to comment #1)
I assume that the bug is that this check is not done
elsewhere; but where, exactly?
I think he means on [[Special:SpecialPages]], where "Log in / create account" is one of the pages listed.
(In reply to comment #2)
I think he means on [[Special:SpecialPages]], where "Log in / create account"
is one of the pages listed.
In this case, this bug is a duplicate of bug 20115.
So you'll need to explain what you want *exactely*, since for now I don't see the difference with bug 20115.
(In reply to comment #5)
Sorry, I should have reiterated that bug 20115 is talking about the HTML <head> part of Special:UserLogin, while this bug is talking about what one sees on Special:Specialpages.
karun.84 wrote:
It looks like this bug has already been fixed in the version of the wiki i am using.
As of r60557 one still sees offers to "sign up", "create account",
although there is no way for the user to create an account, as we have turned that off
in LocalSettings.php. So the user sees links which will just lead to disappointment.
So don't mention creating accounts here if not possible.
$ w3m -dump http://abj.jidanni.org/index.php?title=Special:SpecialPages |
egrep 'sign up|create'
Login / sign up
• Log in / create account
On a related note the group name shows "Login / sign up" instead of login on Special:SpecialPages.
Created attachment 8439
Patch to fix Special:SpecialPages
This patch fixes both messages.
Attached: