Page MenuHomePhabricator

Bot edits should be marked automatically as sighted
Closed, ResolvedPublic

Description

Author: danny.leinad

Description:
After code update, projects with FlaggedRevs has quite big problem... edits made by bots do not be marked automaticly as sighted.


Version: unspecified
Severity: critical

Details

Reference
bz19207

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 21 2014, 10:36 PM
bzimport set Reference to bz19207.
bzimport added a subscriber: Unknown Object (MLST).

checkAutoPromote() should do this already

In any case, I can confirm that bot edits are not autosighted. See for example [[hu:Special:Contributions/TXiKiBoT]] (which had bot flag on hu.wp for years): most of the lines without background color are edits where the bot edited a sighted page, and turned it into a draft.

danny.leinad wrote:

(In reply to comment #2)

checkAutoPromote() should do this already

Can you check whether it works? I don't see any special page with log, so I don't know how it check... ;/

On pl.wiki we temporarily grant bots editor flag, but it isn't a solution.

(In reply to comment #3)

In any case, I can confirm that bot edits are not autosighted. See for example
[[hu:Special:Contributions/TXiKiBoT]] (which had bot flag on hu.wp for years):
most of the lines without background color are edits where the bot edited a
sighted page, and turned it into a draft.

And this: http://uk.wiktionary.org/w/index.php?title=%E5%B8%82&diff=86435&oldid=86339 is not autosighted too

gondnok555 wrote:

Yes (at least on huwiki).

danny.leinad wrote:

(In reply to comment #7)

Yes (at least on huwiki).

Also on plwiki and dewiki ;/

pgrawehr wrote:

Setting prio to high, this needs fixing ASAP. Bots are causing thousands of pages to become unsighted on dewiki. We also have to many bots to either give them all editor rights or block them.

danny.leinad wrote:

Tim added to local conf "$wgGroupPermissions['bot']['review'] = true;" and now it works (previously was "$wgGroupPermissions['bot']['autoreview'] = true;" and it didn't work).

pgrawehr wrote:

(In reply to comment #10)

Tim added to local conf "$wgGroupPermissions['bot']['review'] = true;" and now
it works (previously was "$wgGroupPermissions['bot']['autoreview'] = true;" and
it didn't work).

Yea, I asked him to do this as a quick workaround, because the problem was really getting serious, at least on dewiki. Obviously, this is not a solution, but it shows rather clearly that the problem has something to do with the fact that the "autoreview" feature is broken. A fix is being worked on.

Live now, removed review permission workaround.