Page MenuHomePhabricator

Bugs connected with FlaggedRevs
Closed, ResolvedPublic

Description

Author: danny.leinad

Description:
After code update occurred following bugs:

  1. edit made by editor and marked automatically as sighted still display with red exclamation mark (also on RecentChanges)
  2. disappeared link "(review)" (a few months ago it was enabled, look bug16636)

Version: unspecified
Severity: enhancement

Details

Reference
bz19214

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:37 PM
bzimport set Reference to bz19214.
bzimport added a subscriber: Unknown Object (MLST).

danny.leinad wrote:

  1. Newly created pages by editor don't be automatically marked as reviewed.

*** Bug 19206 has been marked as a duplicate of this bug. ***

(In reply to comment #2)

  1. Newly created pages by editor don't be automatically marked as reviewed.

Fixed in r51925

claymore.ws wrote:

  1. Stable versions of pages are shown by default even though the pages are not stabilized.

(In reply to comment #5)

  1. Stable versions of pages are shown by default even though the pages are not

stabilized.

What wiki is this?

(In reply to comment #0)

After code update occurred following bugs:

  1. edit made by editor and marked automatically as sighted still display with

red exclamation mark (also on RecentChanges)

  1. disappeared link "(review)" (a few months ago it was enabled, look bug16636)
  1. Fixed in r51929

(In reply to comment #7)

ruwiki

flaggedrevsstable preference default was wrong, fixed to "false" in r51931

Edits made by bots after sighted edit are not autosighted too (for example: http://uk.wiktionary.org/w/index.php?title=%E5%B8%82&diff=86435&oldid=86339 )

(In reply to comment #10)

Edits made by bots after sighted edit are not autosighted too (for example:
http://uk.wiktionary.org/w/index.php?title=%E5%B8%82&diff=86435&oldid=86339 )

See bug 19207. These really should be separate.

danny.leinad wrote:

(In reply to comment #10)

Edits made by bots after sighted edit are not autosighted too (for example:
http://uk.wiktionary.org/w/index.php?title=%E5%B8%82&diff=86435&oldid=86339 )

This issue has been reported in bug19207.

danny.leinad wrote:

(In reply to comment #13)

  1. Some reviewed edits are shown as unreviewed in a watchlist. For example:

http://ru.wikipedia.org/w/api.php?action=query&prop=revisions&titles=Вооружённый%20конфликт%20в%20Южной%20Осетии%20(2008)&rvprop=user|comment|flags|flagged|ids&rvstartid=16435729&rvlimit=1
.

From my observation, only edits made between r51863 and r51943 have these damage. After syncing revision with correction 1)-4) it works correctly.

Changing Product: Wikimedia → Mediawiki extensions
Changing Component: WikiBugs → Flagged Revs
Reason: The wikibugs component is designed for the I.R.C. bot[1].

[1]. https://bugzilla.wikimedia.org/describecomponents.cgi?product=Wikimedia

danny.leinad wrote:

  1. (connected with issue 1.) Newly created pages by editor are marking automatically as sighted, but:
  2. on RC and Watchlist still display with red exclamation mark (only with one version in history, after next one edition red exclamation mark disappear)
  3. on [[Special:NewPages]] still display on yellow background (only with one version in history...)

claymore.ws wrote:

This is exactly my (5) issue, with more details.

(In reply to comment #14)

(In reply to comment #13)

  1. Some reviewed edits are shown as unreviewed in a watchlist. For example:

http://ru.wikipedia.org/w/api.php?action=query&prop=revisions&titles=Вооружённый%20конфликт%20в%20Южной%20Осетии%20(2008)&rvprop=user|comment|flags|flagged|ids&rvstartid=16435729&rvlimit=1
.

From my observation, only edits made between r51863 and r51943 have these
damage. After syncing revision with correction 1)-4) it works correctly.

Yes, the fix doesn't retroactively mark off some of the errant RC items.

(In reply to comment #16)

  1. (connected with issue 1.) Newly created pages by editor are marking

automatically as sighted, but:

  • on RC and Watchlist still display with red exclamation mark (only with one

version in history, after next one edition red exclamation mark disappear)

  • on [[Special:NewPages]] still display on yellow background (only with one

version in history...)

Can't reproduce locally.

danny.leinad wrote:

(In reply to comment #19)

(In reply to comment #16)

  1. (connected with issue 1.) Newly created pages by editor are marking

automatically as sighted, but:

  • on RC and Watchlist still display with red exclamation mark (only with one

version in history, after next one edition red exclamation mark disappear)

  • on [[Special:NewPages]] still display on yellow background (only with one

version in history...)

Can't reproduce locally.

Sorry, but I don't understand...

Red exclamation mark means unreviewed pages or outdated reviewed pages. When editor create article, revision has mark "[automatically sighted]", so on Watchlist and RC this page shouldn't be show with red exclamation mark.

Am I mistaken?

danny.leinad wrote:

(In reply to comment #21)

Alas, some autoeditors edits are still not marked as autoreviewed, see
http://ru.wikipedia.org/w/api.php?action=query&prop=revisions&titles=Харлем&rvprop=user|comment|flags|flagged|ids&rvstartid=16464709&rvlimit=1,
for example.

And also other type of "autoeditor" have the same problem... (ru.wiki has users with special right - bug15478, pl.wiki has autopromoted users with 'autoreview' permission - r47252).

Example: http://pl.wikipedia.org/wiki/Dyskusja_wikipedysty:Mathiasrex - after code update, user's edits aren't marking as autoreviewed.

(In reply to comment #20)

(In reply to comment #19)

(In reply to comment #16)

  1. (connected with issue 1.) Newly created pages by editor are marking

automatically as sighted, but:

  • on RC and Watchlist still display with red exclamation mark (only with one

version in history, after next one edition red exclamation mark disappear)

  • on [[Special:NewPages]] still display on yellow background (only with one

version in history...)

Can't reproduce locally.

Sorry, but I don't understand...
Red exclamation mark means unreviewed pages or outdated reviewed pages. When
editor create article, revision has mark "[automatically sighted]", so on
Watchlist and RC this page shouldn't be show with red exclamation mark.
Am I mistaken?

I'm refering to my test wiki.

I can see the yellow NP line issue on dewiki, ugh

  1. Fixed in r52075 (slave lag issue)

danny.leinad wrote:

(In reply to comment #22)

(In reply to comment #21)

Alas, some autoeditors edits are still not marked as autoreviewed, see
http://ru.wikipedia.org/w/api.php?action=query&prop=revisions&titles=Харлем&rvprop=user|comment|flags|flagged|ids&rvstartid=16464709&rvlimit=1,
for example.

And also other type of "autoeditor" have the same problem... (ru.wiki has users
with special right - bug15478, pl.wiki has autopromoted users with 'autoreview'
permission - r47252).

Example: http://pl.wikipedia.org/wiki/Dyskusja_wikipedysty:Mathiasrex - after
code update, user's edits aren't marking as autoreviewed.

Hmmm... You overlooked above issue - #7.

danny.leinad wrote:

Sorry, but I find next issue...

  1. On page [[Special:ListGroupRights]] in bot group lack info about 'autoreview' permission.

As I said above, any other issue should go in their own bug. This is getting harder and harder to read.

danny.leinad wrote:

:(
You are inconsistent, first you mark bug19206 as duplicate of this, a than you didn't resolve this problem, because you are complaining about too many issues.

I've reopened bug19206 and report new bug19269.

(In reply to comment #29)

:(
You are inconsistent, first you mark bug19206 as duplicate of this, a than you
didn't resolve this problem, because you are complaining about too many issues.
I've reopened bug19206 and report new bug19269.

I didn't request that other issues be raised as separate bugs until comment #11; I should have said that sooner, but was only expecting 2-3 items would be posted here. REOPENing is fine.