Page MenuHomePhabricator

Recent software changes broke the Abuse Filter
Closed, ResolvedPublic

Description

I'm not sure exactly how widespread the problems are, but multiple important keywords seem to have been broken in the update as shown in both the batch testing interface and in live rules (e.g. the log of Rule 180).

Known problem keywords:

added_lines, removed_lines

Examples of bad behavior:

length(added_lines) < 100 is sometimes True on edits adding thousands of characters.
length(removed_lines) < 100 is sometimes True on edits removing thousands of characters.
contains_any(added_lines, ... ) is sometimes False even when the diff and examine interface say it should be True.

A large number of existing rules that either aren't working or are working only erratically may need to be disabled until this is fixed.


Version: unspecified
Severity: major

Details

Reference
bz19216

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:37 PM
bzimport added a project: AbuseFilter.
bzimport set Reference to bz19216.

Is this still the case?

Are there examples?

Have you isolated a test case?

Discussion on http://en.wikipedia.org/wiki/Wikipedia_talk:Abuse_Filter#Massive_triggering_of_filter_28 seems to indicate that it wasn't the vast problem described.

Look at the very large diffs being matched by "length(added_lines) < 100" in batch testing

Or for a more specific example try '!contains_any(added_lines,"[[","{{")' for User:Naraht. There are many examples that match even though they contain [[. Similar examples are also present in log 180 until it was disabled.

(In reply to comment #2)

Look at the very large diffs being matched by "length(added_lines) < 100" in
batch testing

Or for a more specific example try '!contains_any(added_lines,"[[","{{")' for
User:Naraht. There are many examples that match even though they contain [[.
Similar examples are also present in log 180 until it was disabled.

Batch testing seems to be broken. Matches according to the batch test, but not according to 'examine'. Not sure if the actual filters are broken.

Based on 180 in particular, I think it is affecting actual filters, but possibly only in rare circumstances.

I'm not sure it is related or not, but the frequency of condition limited events also seemed to jump with the update.

I've found the buggy code in question, and I'm working on a fix.

Fixed in r51970 and deployed on Wikimedia sites.