Page MenuHomePhabricator
Create Task
Maniphest T21393

Feeds format dates in content language and other messages in user language
Closed, ResolvedPublic
Actions

Description

Use $wgLang for date formatting, not $wgContLang

The „revision as of“ message shown above the diff in feeds (page history feeds, RC feed) displays the date in the content-language format, but the text of the message (and many other items in the feed) are in the user’s preferred language. See the URL for an example.

Note that this might have been an attempt to make the feed language-independent, but that fails in many ways. See also bug #19391.

Version: unspecified
Severity: trivial
URL: http://en.wikipedia.org/wiki/Foo?action=history&feed=rss&uselang=ar

Attached:

FeedUtils.php.diff955 BDownload

Details

Reference
bz19393

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:42 PM
• bzimport added projects: MediaWiki-Internationalization, good first task.
• bzimport set Reference to bz19393.
• bzimport added a subscriber: Unknown Object (MLST).
Mormegil created this task.Jun 25 2009, 4:01 PM
siebrand added a comment.Jun 27 2009, 8:29 AM

Hmm, tough one. The above is not a fix I think. It's killing one symptom. First question is: should a feed always be in content language? If so, all text elemenents should be checked and rendered in the content language.

Is anyone able to provide clarity on the expected behaviour of the feed with regards to language?

Mormegil added a comment.Jun 27 2009, 10:23 AM

I don’t think this is a tough bug... The tough thing is in bug #19391. This is just a trivial fix, so that the feed is at least _consistent_. Note that currently, _everything except the date_ is in the user’s language, not content language. (Heck, the date itself is just one of parameters to wfMsg, not wfMsgForContent!)

The issue whether the feed should be changed to use the content language always (and how to achieve that nontrivial problem – think about the formatting of log entries in the feed!) would be better debated in bug #19391, IMHO. (I have also provided a link to a relevant bug #17868 there.)

• bzimport added a comment.Jan 2 2010, 11:23 PM

karun.84 wrote:

(In reply to comment #2)

I don’t think this is a tough bug... The tough thing is in bug #19391. This
is just a trivial fix, so that the feed is at least _consistent_. Note that
currently, _everything except the date_ is in the user’s language, not
content language. (Heck, the date itself is just one of parameters to wfMsg,
not wfMsgForContent!)

The issue whether the feed should be changed to use the content language always
(and how to achieve that nontrivial problem – think about the formatting of
log entries in the feed!) would be better debated in bug #19391, IMHO. (I have
also provided a link to a relevant bug #17868 there.)

Looks like bug #19391, bug #17868 have been resolved.
Does the issue reported in this bug still occur?

Mormegil added a comment.Jan 3 2010, 3:30 PM

(In reply to comment #3)

Looks like bug #19391, bug #17868 have been resolved.
Does the issue reported in this bug still occur?

Sure, it does. Check the linked URL, it contains items like “مراجعة أقدممراجعة 14:10, 19 August 2009” – interspersing English date with Arabic text.

Those two bugs are not duplicates of this, or anything like that.

IAlex added a comment.Apr 2 2010, 3:47 PM

Done in r64521.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL