Is the parser output only partially used?
$parser->mOutput->addHeadItem( self::buildHeadItem( $geshi ), "source-{$lang}" );
Version: unspecified
Severity: minor
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/52676#c3073
Description
Description
Details
Details
- Reference
- bz19474
Event Timeline
Comment Actions
Not sure I understand this; geshi syntax highlighting isn't used on this page that I can see, so it's not surprising that the geshi styles aren't being pulled in?
Comment Actions
The HTML output for comments is fetched via $wgOut->parse(), which throws away any head items or ResourceLoader modules specified in the ParserOutput object.
Without redoing the entire output code for the code review pages, this might work:
- change out $wgOut->parse() for
- call $wgOut->addParserOutputNoText($parserOutput) to add styles/etc
- note this will pass through language links and category links as well. Alternate: just do the head items/addModules but this feels icky.
- fetch the HTML with $parserOutput->getText() and use as before
Comment Actions
(In reply to comment #3)
The HTML output for comments is fetched via $wgOut->parse(), which throws away
any head items or ResourceLoader modules specified in the ParserOutput object.Without redoing the entire output code for the code review pages, this might
work:
- change out $wgOut->parse() for
- call $wgOut->addParserOutputNoText($parserOutput) to add styles/etc
- note this will pass through language links and category links as well.
Alternate: just do the head items/addModules but this feels icky.
- fetch the HTML with $parserOutput->getText() and use as before
Care to elaborate a bit more Brion?
Was just looking at this, and the idea doesn't seem complete...
ie Which parser output instance you are using, etc
Ta! :)