Hook 'EditFilterMerged' should be called after 'force edit summary' preference is enforced
Open, LowPublic
Actions

Assigned To

None

Authored By

	seth
	Jul 8 2009, 9:28 PM

Description

See e.g. [http://de.wikipedia.org/w/index.php?title=Spezial:Missbrauchsfilter-Logbuch&wpSearchFilter=4]: There is a log entry
:"2009-06-16T21:30:44: 90.136.148.123 [...] triggered filter 4, performing the action "edit" on [[:de:Stempeltechnik]]. Actions taken: none; [...]".
Although rule #4 does not disallow changes (it just logs them), you can't see the change of [[:de:Stempeltechnik]], when you have a look at [[:de:special:contributions/90.136.148.123]]. So what happened there? I gave some more of these examples at [http://en.wikipedia.org/wiki/User_talk:Werdna/Archive_1#63364096679].

Version: 1.16.x
Severity: normal

Details

Reference: bz19605

	Subject	Repo	Branch	Lines +/-
	Handle edit summary preferences before calling edit filter hook	mediawiki/core	master	+5 -4

Customize query in gerrit

Related Objects

Duplicates Merged Here: T132869: Endless loop between forceeditsummary and Abusefilter warnings

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 10:42 PM

• bzimport added a project: MediaWiki-Page-editing.

• bzimport set Reference to bz19605.

• bzimport added a subscriber: Unknown Object (MLST).

seth created this task.Jul 8 2009, 9:28 PM

Bug 19680 has been marked as a duplicate of this bug. ***

Prodego wrote:

When a user is given a warning they must click save a second time in order to save the edit. If they don't do this, the edit is not saved, so nothing will happen.

(batch change)

Minor bugs that nevertheless need looking into

(In reply to comment #2)

of course, i know that. the rule i'm talking about does not give a warning and does not disallow edits, it just should log them.

For some reason the check for 'force edit summary' is after the hook that AbuseFilter uses.

This option is on by default on de.wikipedia.org — so I'll bet that's what happened.

Unassigning from me, adding some CCs to get wider feedback on whether it should be moved.

• werdna unsubscribed.Dec 10 2014, 6:16 PM

DannyS712 closed this task as a duplicate of T132869: Endless loop between forceeditsummary and Abusefilter warnings.Dec 5 2019, 3:57 AM

Jdforrester-WMF reopened this task as Open.Dec 5 2019, 6:07 PM

Jdforrester-WMF merged a task: T132869: Endless loop between forceeditsummary and Abusefilter warnings.

Jdforrester-WMF added subscribers: Ltrlg, Jdforrester-WMF, Nullzero and 3 others.

Daimona added a project: AbuseFilter.Dec 5 2019, 6:15 PM

Change 559901 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Handle edit summary preferences before calling edit filter hook

https://gerrit.wikimedia.org/r/559901

gerritbot added a project: Patch-For-Review.Dec 20 2019, 4:27 PM

Change 559901 abandoned by Ammarpad:
[mediawiki/core@master] Handle edit summary preferences before calling edit filter hook

Reason:
not working on this