Page MenuHomePhabricator

Cannot view Special:Contributions (possible regression from r53534)
Closed, ResolvedPublic

Description

Author: accnospamtom

Description:
starting with this revision, I ran into trouble when using update.php.

After updating, I cannot access one users contributions.
Instead I only get a white page (in Opera) or a connection error (in IE8).

When downloading a higher revision (tried r53550) and _not_ running the update script, everything seems fine.


Version: 1.16.x
Severity: normal

Details

Reference
bz19845

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:38 PM
bzimport set Reference to bz19845.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to comment #0)

starting with this revision, I ran into trouble when using update.php.

What kind of trouble? Error messages? Exceptions? Just failed to run? You'll have to be more specific.

And it seems odd that this rev would break update.php, but I dunno.

accnospamtom wrote:

(In reply to comment #1)

(In reply to comment #0)

starting with this revision, I ran into trouble when using update.php.

What kind of trouble? Error messages? Exceptions? Just failed to run? You'll
have to be more specific.

And it seems odd that this rev would break update.php, but I dunno.

Update.php runs fine, no error messages.

After checkout from SVN and running update.php, I accidentally clicked the following link:

http://test.kamelopedia.mormo.org/index.php/Spezial:Beiträge/Dufo

And I only got ... nothing (or a connection error in IE8).

http://test.kamelopedia.mormo.org/index.php/Spezial:Beiträge/BoTeule

for example showed up fine.

If I only check out the last revision (r53554), nothing brakes (the first users contributions show up fine). It is only after running update.php, that this bug occurs.

I checked out several revisions between (r53472 and r53550) to approach the revision, which "introduced" this behavior ... and it was exactly r53534 which triggerd the described effect.

This is the Linker.php diff for that revision:

http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/Linker.php?r1=53534&r2=53533&pathrev=53534

Maybe Linker.php is somhow used while update.php is running (I'm no developer and barely speak english, sorry for that)

It must have something to do with Linker.php, because if I check out the last revision of MW and than manually replace Linker.php with its last revision before r53534, and then run update.php everything is fine ...

Are there any relevant lines in the Apache/PHP error log? If not, look in php.ini and make sure 'log_errors' is set to true and 'error_log' is set to a file writable by the webserver, then try again (you may need to restart apache for the settings change to take effect)

accnospamtom wrote:

error logging seems to be off (php -i says so).

I only have access to the kamelopedia/ test.kamelopedia subdomains of mormo.org (no root access), so I cannot change anything.

But in the meantime, I found, that especially old accounts are affected by those bug.

The database at test.kamelopedia is a copy of the original database of Kamelopedia (which was created back in April 2004). I remembered, that user Dufo (from the example above) joined us very early, so I checked some contributions from accounts I know were created in 2004/ 2005 ... and all those give me the blank page as described above.

I will try to import Kamelopedias database to my local wiki an my Laptop and try to replicate that bug, so I can add relevant error log lines here ...

accnospamtom wrote:

(In reply to comment #6)

The error seems to be caused by
http://test.kamelopedia.mormo.org/index.php?oldid=319291&diff=prev since
http://test.kamelopedia.mormo.org/index.php/Spezial:Beitr%C3%A4ge/Dufo?limit=2
works but
http://test.kamelopedia.mormo.org/index.php/Spezial:Beitr%C3%A4ge/Dufo?limit=3
doesn't (I used
http://test.kamelopedia.mormo.org/api.php?action=query&list=usercontribs&ucuser=Dufo
to get your other contributions). Can you follow the instructions on
http://www.mediawiki.org/wiki/Manual:Errors_and_Symptoms#You_see_a_Blank_Page
so that we could be able to see the exact error? (I already tried about
everything on my test wiki but could not reproduce.)

Thanks. Enabling logging as proposed doesn't show anything.

But you helped me quite a lot, as it seems, that the blank page only occurs for users with reverts in their (not shown) contributions (with the default german summary message for [[MediaWiki:Revertpage]]).

Another thing: I commented out one extension in localsettings.php (because we do not use it anymore), and after that, contributions showed up fine _once_ (reloading the page resulted in the blank page syndrome).

So I disabled _all_ extensions (stupid, should have done that _first_), and after that, everything seems fine. We have quite a lot of extensions, so I need some time to check out which extension(s) cause that bug ...

accnospamtom wrote:

Hmm, it seems that the LinkedImage-Extension causes this bug [http://www.mediawiki.org/w/index.php?title=Extension:LinkedImage&oldid=245470].

Very strange (why does it break Special:Contributions at all and why only if revert-contributions exist?!)

As MWs core now offers a similar functionality it's not a real problem to abandon that extension ...

accnospamtom wrote:

(In reply to comment #8)

Hmm, it seems that the LinkedImage-Extension causes this bug
[http://www.mediawiki.org/w/index.php?title=Extension:LinkedImage&oldid=245470].

Very strange (why does it break Special:Contributions at all and why only if
revert-contributions exist?!)

Ahh, r53534 did changes to Linker.php ... so of course that could brake Extension:LinkedImage ... (but that shouldn't break MWs other functionalities like Special:Contributions ...

As MWs core now offers a similar functionality it's not a real problem to
abandon that extension ...

accnospamtom wrote:

Found something in my local error_log:

[Wed Jul 22 19:46:24 2009] [error] [client 127.0.0.1] (20024)The given path is misformatted or contained invalid characters: Cannot map GET /testkamelopedia/index.php/Spezial:Beitr%C3%A4ge/Dufo HTTP/1.1 to file

[5120] EACCELERATOR: PHP crashed on opline 46 of preg_replace_callback() at C:\xampp\htdocs\testkamelopedia\includes\Linker.php:1025

I imported the kamelopedia database and could replicate the bug. I'm using XAMPP on Vista, and this bug crashes appache completely.

In addition: Histories of other pages are also affected, and this also happens with _all_ extensions disabled. So I was totally wrong assuming that Extension:LinkedImage was causing this behavior ...

Something in Linker.php (as of r53524) is causing this

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/53534

What version of PHP were you using when you tested it on Windows?

accnospamtom wrote:

(In reply to comment #11)

What version of PHP were you using when you tested it on Windows?

PHP 5.2.8 (apache2handler)

Someone experienced a similar error, see http://lists.wikimedia.org/pipermail/mediawiki-l/2009-August/031809.html (same file, same line). Try to update your PHP version and see it still occurs.

Should be fixed with r55644 (by reverting r53534)