Page MenuHomePhabricator

Wrong parameter in gadgets loading
Closed, ResolvedPublic

Description

In the HTML, it's using

<script type="text/javascript" src="/w/index.php?title=MediaWiki:Gadget-mycommon.js&amp;action=raw&amp;ctype=text/javascript?230"></script>

to load gadgets now. But "?230 is completely wrong. It means the value of ctype parameter is "text/javascript?230". It stops gadgets from being loaded. Firefox says:

The resource from this URL is not text: http://zh.wikipedia.org/w/index.php?title=MediaWiki:Gadget-mycommon.js&action=raw&ctype=text/javascript?230

Remove "?230" or change it to "&230" please.


Version: unspecified
Severity: blocker

Details

Reference
bz19852

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 21 2014, 10:38 PM
bzimport set Reference to bz19852.

I'm not really sure we should be appending $wgStyleVersion to Gadget URLs. They need to be purged when updated, yes, but $wgStyleVersion doesn't update on Gadget changes, making it basically useless.

Suggest removal, not changing it to &nnn.

Maybe we can append revision id (oldid) of that gadget page to the end of url.

mike.lifeguard+bugs wrote:

r53376 seems to fix this.

  • Bug 20396 has been marked as a duplicate of this bug. ***