Page MenuHomePhabricator

"Cite this page" toolbox link does not have a title attribute
Closed, ResolvedPublic

Description

I'm not sure if Special:Cite and this link are actually added by the Cite extension, but i don't think it's part of the core software either. If Cite is the incorrect extension, please reclassify this.


Version: unspecified
Severity: trivial

Details

Reference
bz20218

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:47 PM
bzimport set Reference to bz20218.

I tried to write a patch. At this occasion, I changed the way how to add the link to the toolbar. Maybe a more experienced coder can take a look at it. Thanks.

Created attachment 6570
adds the missing "title"-tag and changes the way how to add the patch

attachment citetitle.patch ignored as obsolete

Created attachment 6572
improved version of the previous posted patch

improved the previous posted patch. basically, it does the same, but in a better way ;)

attachment citetitle.patch ignored as obsolete

Created attachment 6573
third version. simplifies the 2nd version.

This patch does basically the same as the two patches already posted. But: The code is less, and functions we don’t need are deleted.

We don’t have to check whether the special page “cite” exists because we required the extension containing the page (it’s defined in the same extension).

attachment citetitle.patch ignored as obsolete

Created attachment 6574
The real 3rd version

I’m so sorry I selected the wrong file -- this is what I pronounced as Patch Nr. 3 ^^

attachment citetitle.patch ignored as obsolete

Minor tweaks, merging wfSpecialCiteToolboxCite to wfSpecialCiteToolbox

Note that the patches introduced a small bug:

On non-existing pages, the Cite-Link is displayed. @Ireas: please fix it :)

attachment truepatch ignored as obsolete

Created attachment 6577
adds title tag to toolbar link, simplifies the code

This should really fix all issues ;)

Attached: