Page MenuHomePhabricator

broken html tag on "Files" tab of preferences
Closed, ResolvedPublic

Description

A screenshot of the problem on my site.

In 1.15.1, on the "files" tab of preferences, this is the text i see:

Image size limit:<br />''(for file description pages)''

The html tag shouldn't be showing as text.


Version: 1.15.x
Severity: trivial
URL: http://tmbw.net/wiki/Special:Preferences?useskin=monobook#prefsection-2

Attached:

prefs-files.jpg (636×1 px, 99 KB)

Details

Reference
bz20239

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:49 PM
bzimport set Reference to bz20239.

plitanium wrote:

Proposed Patch

The Xml::label function uses Xml::element which further employs the use of htmlspecialchars. htmlspecialchars converted the '<' and '>' tags to &lt and &gt respectively.

attachment bugfix_20239.diff ignored as obsolete

(In reply to comment #1)

Created an attachment (id=6465) [details]
Proposed Patch

Just revert the affected message to the previous version (or remove the <br />), no need to touch code.

plitanium wrote:

Better to use the old text

Reverting to the text in Revision 48780

Attached: