Page MenuHomePhabricator
Create Task
Maniphest T22288

diffs between revisions which are both deleted & suppressed
Closed, ResolvedPublic
Actions

Description

Suppressed edits which are not deleted display the message [[MediaWiki:Rev-deleted-unhide-diff]]:

"One of the revisions of this diff has been deleted. There may be details in the deletion log.
As an administrator you can still view this diff if you wish to proceed."

e.g.

https://secure.wikimedia.org/wikipedia/en/w/index.php?title=User_talk:Nakon&diff=308209837&oldid=307073985

However if the revision has been deleted, there are two problems:

  1. the log has a (diff) link which does not work:

https://secure.wikimedia.org/wikipedia/en/w/index.php?title=Special:Log&offset=200906161852&limit=5&type=suppress

  1. the special:undelete page has a (diff) link which does work, however it display neither the diff nor [[MediaWiki:Rev-deleted-unhide-diff]], and adding &unhide=1 does not work.

https://secure.wikimedia.org/wikipedia/en/w/index.php?title=Special:Log&offset=20090403232052&limit=3&type=suppress

However I have also noticed that it does show a _broken_ diff here:

https://secure.wikimedia.org/wikipedia/en/w/index.php?title=Special:Undelete&target=User%3ADominic%2F&timestamp=20090326110928&diff=prev

Version: unspecified
Severity: normal

Details

Reference
bz20288

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 10:52 PM
• bzimport added a project: MediaWiki-Revision-deletion.
• bzimport set Reference to bz20288.
• bzimport added a subscriber: Unknown Object (MLST).
jayvdb created this task.Aug 17 2009, 1:46 PM
• bzimport added a comment.Feb 21 2013, 11:49 PM

sumanah wrote:

John Mark, is this still reproducible? Thanks!

Aklapper added a comment.Apr 11 2013, 1:20 PM

John Mark, is this still reproducible?

TTO added a comment.Feb 11 2014, 12:49 AM

It's difficult to analyse the links provided, as few users have oversight rights on enwiki. If a test case could be set up on testwiki, it would be easier to understand the issue.

Risker added a comment.Feb 11 2014, 2:17 AM

Updating based on current URLs:

This is the diff in question: https://en.wikipedia.org/w/index.php?title=User_talk:Nakon&diff=308209837&oldid=307073985

It is clearly suppressed. When clicking on the "del/undel" button, I am taken to the page that confirms it is suppressed. However, there is no entry in the suppression log, either on the delete/undelete page ( https://en.wikipedia.org/w/index.php?title=Special:RevisionDelete&type=revision&target=User_talk%3ANakon%2Farc6&ids=308209837 ) or when looking at Special:Log for suppression for the date 15 August 2009 at 23:41. It is also not listed as being deleted on the Delete/undelete revisions page, or on the Special:Log for deletion for the date 15 August 2009 at 23:41. The edit appears in the page history, and as an oversighter I can view the diff involved. Given the nature of the reason for suppression, I'm hesitant to play around with trying to unsuppress and resuppress.

duplicatebug unsubscribed.Dec 13 2014, 11:44 AM
Nemo_bis added a subtask: T23175: Add log excerpts to revdeleted diffs.Apr 26 2015, 6:04 PM
• Phabricator_maintenance removed a subscriber: • wikibugs-l-list.Aug 5 2016, 2:26 PM
Restricted Application added a subscriber: JEumerus. · View Herald TranscriptAug 5 2016, 2:26 PM
• Phabricator_maintenance removed a parent task: T20840: [DO NOT USE] RevDelete/HideUser (tracking) [superseded by #MediaWiki-Revision-deletion].Aug 5 2016, 2:28 PM
Amorymeltzer subscribed.Nov 17 2018, 11:54 AM
Meno25 unsubscribed.Nov 23 2018, 7:43 AM
Umherirrender closed this task as Resolved.Jan 5 2023, 7:33 PM
Umherirrender subscribed.

Answer for no 1.
The action links on Special:Log/delete or Special:Log/suppress for revdel actions can contain a (diff) link, this (diff) link does not check if the revision was deleted in the meantime and that can make the link broken. When clicking "change visibility" and diff on that page it works. As one task should contain one issue, I created a new task for this: T326348

Answer for no 2.
I cannot see "broken" diffs when looking at suppressed diffs of deleted pages on my own wiki, that point seems to be fixed in the meantime, marking this task as resolved.

In T22288#255074, @Risker wrote:

Updating based on current URLs:

This is the diff in question: https://en.wikipedia.org/w/index.php?title=User_talk:Nakon&diff=308209837&oldid=307073985

It is clearly suppressed. When clicking on the "del/undel" button, I am taken to the page that confirms it is suppressed. However, there is no entry in the suppression log, either on the delete/undelete page ( https://en.wikipedia.org/w/index.php?title=Special:RevisionDelete&type=revision&target=User_talk%3ANakon%2Farc6&ids=308209837 ) or when looking at Special:Log for suppression for the date 15 August 2009 at 23:41. It is also not listed as being deleted on the Delete/undelete revisions page, or on the Special:Log for deletion for the date 15 August 2009 at 23:41. The edit appears in the page history, and as an oversighter I can view the diff involved. Given the nature of the reason for suppression, I'm hesitant to play around with trying to unsuppress and resuppress.

When a suppression missed a log, there is no way to create a log entry afterwards. It could be a small time of a software error which results in this situation or the log exists under another page name.
For very old suppressions it is possible that the suppression was done with the old oversight extension and that was using other logs.

Amorymeltzer added a comment.EditedJan 5 2023, 8:46 PM
In T22288#8502696, @Umherirrender wrote:

When a suppression missed a log, there is no way to create a log entry afterwards. It could be a small time of a software error which results in this situation or the log exists under another page name.
For very old suppressions it is possible that the suppression was done with the old oversight extension and that was using other logs.

For this specific case, @Umherirrender, it's because the page was moved after suppression. I'm moderately confident that more recent updates to move logs and revel stuff means more recent stuff will behave better, but that stuff wasn't done retroactively. Doesn't change any status of any tasks, just figured I'd mention.

Umherirrender added a comment.Jan 5 2023, 9:01 PM
In T22288#8502967, @Amorymeltzer wrote:
In T22288#8502696, @Umherirrender wrote:

When a suppression missed a log, there is no way to create a log entry afterwards. It could be a small time of a software error which results in this situation or the log exists under another page name.
For very old suppressions it is possible that the suppression was done with the old oversight extension and that was using other logs.

For this specific case, @Umherirrender, it's because the page was moved after suppression. I'm moderately confident that more recent updates to move logs and revel stuff means more recent stuff will behave better, but that stuff wasn't done retroactively. Doesn't change any status of any tasks, just figured I'd mention.

Thanks for have a look. Move of revdel logs is tracked as T214551: RevisionDeletion log does not move to new title after page move.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL