Page MenuHomePhabricator

PHP 5.3.0 throws hooks into an error
Closed, ResolvedPublic

Description

Author: jnfsmile

Description:
I wasn't sure, at first this looks like an extension bug, but I think at the core it's really a general MW bug.

My host upgraded PHP from 5.2.5 to 5.3.0 and hooks went crazy. They're giving me this error message:
"Detected bug in an extension! Hook HOOK FUNCTION NAME failed to return a value; should return true to continue hook processing or false to abort."

This happens to many hook extensions, but not all. I can't figure his out, I think it has to do with PHP 5.3.0 compatibility (functions returning NULL instead of false?).

Because it happened to a bunch of hook at once I believe it's a problem with how MW handles the hooks.


Version: unspecified
Severity: major
URL: http://www.yeshiva.org.il/wiki

Details

Reference
bz20383

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:58 PM
bzimport set Reference to bz20383.
bzimport added a subscriber: Unknown Object (MLST).

Not an issue with PHP5.3. Seems as though your extensions are broken and not returning values from their hooks, like they should. Which extensions are showing the error?

jnfsmile wrote:

(In reply to comment #1)

Not an issue with PHP5.3. Seems as though your extensions are broken and not
returning values from their hooks, like they should. Which extensions are
showing the error?

Official ones: ConfirmEdit, SpamBlackList.
There are a few others I built myself for the project.

For ConfirmEdit this is already fixed, see bug 20371.

Changing Product/Component to MediaWiki extensions/SpamBlackList.