Page MenuHomePhabricator

RCFeed: Expose log_id in RC feed
Closed, ResolvedPublic

Description

Author: matthew.britton

Description:
It would be useful if the IRC recent changes feed included the IDs of log items. Revision IDs are already there in the URLs, but for log items the URL is just [[Special:Log]].


Version: unspecified
Severity: enhancement

Details

Reference
bz20394

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:46 PM
bzimport set Reference to bz20394.

The IRC RC Feed is no longer in development (considered frozen for backwards compatibility).

It is superseded by the JSON RC Feed. Either way, it seems valuable to have this there.

It is already part of the RecentChange object[1], and already exposed in the RecentChanges API query module[2]. Just need to expose it in RCFeedFormatter[3] as well.

[1] https://github.com/wikimedia/mediawiki-core/blob/77f9979e/includes/changes/RecentChange.php#L47
[2] https://github.com/wikimedia/mediawiki-core/blob/77f9979e9/includes/api/ApiQueryRecentChanges.php#L527-L532
[3] https://github.com/wikimedia/mediawiki-core/blob/77f9979e9b6/includes/rcfeed/MachineReadableRCFeedFormatter.php#L40

Change 137853 had a related patch set uploaded by Legoktm:
Expose log_id in RC feed

https://gerrit.wikimedia.org/r/137853

What is the value of having it there?

(In reply to Ori Livneh from comment #3)

What is the value of having it there?

Hm.. good point. How can the log_id be utilised by a consumer? It is not part of a permalink.

If you want to do a database query for whatever reason, you'd probably want the log_id. Or if you want to revdel via the API (RC adminbot watching for bad usernames), the log_id is the id parameter that you'd use.

(In reply to Krinkle from comment #4)

Hm.. good point. How can the log_id be utilised by a consumer? It is not
part of a permalink.

Even though it's not used in linking, it is a permanent unique id for the given log entry, which can be useful if you're storing the events for future usage.

Okay, those two use cases sounds great.

Change 137853 merged by jenkins-bot:
RCFeed: Add log_id property (exposes rc_logid attribute)

https://gerrit.wikimedia.org/r/137853