Page MenuHomePhabricator

AbuseFilter: disable "add at cursor" selection box when user can't edit filters
Closed, ResolvedPublic

Description

Author: matthew.britton

Description:
At the moment, if you view a filter but can't edit it, you can use the "add at cursor" selection box to add stuff to the filter field, even though the field is disabled. You can't save it or anything, but it's still odd. That box should be disabled too.


Version: unspecified
Severity: minor

Details

Reference
bz20472

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:51 PM
bzimport added a project: AbuseFilter.
bzimport set Reference to bz20472.
bzimport added a subscriber: Unknown Object (MLST).

dodo.wikipedia wrote:

Proposed patch

I've attached a proposed patch that would hide the dropdown box and the check syntax button to users who cannot edit filters.

Attached:

Patch applied, with modifications, in r111131.

Thanks for submitting a patch, and sorry that it took more than a year to be applied!