Page MenuHomePhabricator

Commons' "Upload new version" acts as "Upload file" (Firefogg?)
Closed, DeclinedPublic

Description

Trying (I think) the same operation approx. 12 hours ago and now, first I got bug 20667, where uploading new versions of files was impossible; now I'm getting something entirely new - the "Upload new version" acts as a cut-down "Upload file" dialog. Thus, it was uploaded to a new location equal to the filename as it was on my hard drive (different to the on-wiki filename). My "comments" (i.e. edit summary) became the description of the file, but apart from that I could not enter categories, a proper description, licensing info etc etc.

Here what I did:

  1. Go to http://commons.wikimedia.org/wiki/File:Samuel_Parr.jpg (n.b. "jpg" ending)
  2. Press "Upload a new version..."
  3. Choose a source file from my PC, which was saved as Samuel-Parr-H.png (n.b. the "png" ending)
  4. Enter a comment ("Slightly larger, clearer.")

What I expected:
a) Failure like last night
b) In retrospect, uploading a png over a jpg is probably impossible, so maybe an error message or some such.

What I got:
i) http://commons.wikimedia.org/wiki/File:Samuel-Parr-H.png


Version: unspecified
Severity: major

Details

Reference
bz20736

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:56 PM
bzimport set Reference to bz20736.

Bryan.TongMinh wrote:

(In reply to comment #0)

What I got:
i) http://commons.wikimedia.org/wiki/File:Samuel-Parr-H.png

I can't reproduce this. What I get when I follow the steps is that it tries to overwrite the jpg with an png, fails to overwrite the file, but does overwrite the database information.

Bryan.TongMinh wrote:

(In reply to comment #1)

(In reply to comment #0)

What I got:
i) http://commons.wikimedia.org/wiki/File:Samuel-Parr-H.png

I can't reproduce this. What I get when I follow the steps is that it tries to
overwrite the jpg with an png, fails to overwrite the file, but does overwrite
the database information.

Ignore, the "fails to overwrite the file, but does overwrite the database information.", that was an caching problem on my side.

If 20667 is anything to go by, it could be because you're an admin but I'm not. Possibly.

Otherwise, is that jpg file now a png, or was it converted automatically?

I just renamed the local file to equal that of the remote file and the upload worked perfectly (though it did warn me that a file already existed at that filename, which was kind of the point).

Okay, I am now 99% sure this relates either to Firefox 3.5 or, more likely, the Firefogg extension and how it integrates into Commons upload.

Michael, can you take a peek at this?

Looks like Jarry1250 is pulling the copy of remoteMwEmbed.js from metavid.org: http://commons.wikimedia.org/wiki/User:Jarry1250/vector.js

  • Bug 21259 has been marked as a duplicate of this bug. ***

mdale wrote:

Jarry1250: please use the mwEmbed gadget rather than the older metavid script path. Empty out your User:Jarry1250/vector.js
page and enabled the mwEmbed gadget on the gadgets preference page. The gadget should always be point to the "stable" version.

Using firefogg I don't experience the same problems. I just did the following:

  1. went to http://commons.wikimedia.org/wiki/File:Foldergs.ogv
  2. clicked upload new version of this file
  3. selected a new file uploaded it added comment (test force destination name)
  4. it transcodes, uploads and gives me a link to the page.
  5. I confirm a new version has been uploaded: http://commons.wikimedia.org/wiki/File:Foldergs.ogv

Thanks, I changed over and now it all seems to be working. (I had to restart my browser first as well.) I'm glad to see you've updated the documentation in recent weeks as well.

I'm pretty sure it asked me to select a file (erroneously called a "video" despite the .png ending) twice though (once normally, then again once I'd press "Upload".

Also, it should be possible to cancel easily via not selecting a file, but I'm sure you're onto that one.

Thanks again,
Jarry

Just happened to me again, in Google Chrome. http://commons.wikimedia.org/wiki/File:Mixed_incidence.jpg was supposed to be a new version of http://commons.wikimedia.org/wiki/File:Tax_incidence_(mixed).svg .

Then, I hit my back button and tried again, and it uploaded it as a new version - of the wrong file! Eurgh.

Just got exactly the same thing with Internet Explorer 8, uploaded to the wrong location again. I should note that the interface ("Go to resource page") goes straight to the actual target of the upload i.e. the bad filename.

Firefogg seems currently disabled on commons ( bug #42733 ) ? So this bug can be closed?

Closing as per last comment. Please reopen (and provide steps) if this can still be reproduced.

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:24 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:22 AM