Page MenuHomePhabricator
Create Task
Maniphest T22807

Enable site logo displaying according to user language
Closed, DuplicatePublic
Actions

Description

This can allow users to create different logos for different languages.

Details

Reference
bz20807

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:48 PM
• bzimport added a project: MediaWiki-extension-requests.
• bzimport set Reference to bz20807.
• bzimport added a subscriber: Unknown Object (MLST).
liangent created this task.Sep 25 2009, 2:07 PM
• brion added a comment.Sep 25 2009, 4:50 PM

The logo URL isn't really a localization string; it's site-specific and belongs in the general administration interface (which doesn't exist yet).

Danny_B added a comment.Sep 27 2009, 9:32 AM

Multilingual projects such as Wikispecies (besides many others outside WMF) which have localized names for project would utilize some such feature to display logo according to user language.

Changing the summary to more general and reopening. If closing will follow, I'd suggest rather LATER than WONTFIX.

• brion added a comment.Sep 28 2009, 7:02 PM

Hmmm... note that as a hackaround this could be done via site JS for now (check wgUserLanguage and swap out the URL on the logo). Site CSS can also override the logo but I don't think user language is exposed in a way that CSS can consistently get it (the content lang is used on <html lang="xx">)

MarkAHershberger added a comment.Jan 27 2011, 8:37 PM

Related to Bug#14594 which involves different logos for different skins.

While I understand that we have bits of language in different logos, I should note that the golden arches remain the same even in languages that do not use the Latin alphabet: http://www.mylifestylediet.com/blog/latest-news/golden-arches-in-japan-expand-burger-selection-and-calories/

Nikerabbit added a comment.Apr 3 2013, 7:35 AM

This feature looks suitable for an extension rather than core.

Legoktm added a comment.Oct 6 2013, 8:58 AM

There are obviously some caching issues, but this seems to work:

$wgExtensionFunctions[] = function() {
global $wgUser, $wgLogo;
switch ( $wgUser->getOption( 'language' ) ) {

		case 'en':
			$wgLogo = 'en-logo';
			break;
		case 'fr':
			$wgLogo = 'fr-logo';
			break;
		default:
			$wgLogo = 'default-logo';

}
};

DanielFriesen added a comment.Oct 6 2013, 9:01 AM

(In reply to comment #6)

There are obviously some caching issues, but this seems to work:

$wgExtensionFunctions[] = function() {

global $wgUser, $wgLogo;
switch ( $wgUser->getOption( 'language' ) ) {
    case 'en':
        $wgLogo = 'en-logo';
        break;
    case 'fr':
        $wgLogo = 'fr-logo';
        break;
    default:
        $wgLogo = 'default-logo';
}

};

Ugh, $wgUser and varying config on request state.

Please use the SkinTemplateOutputPageBeforeExec to modify logopath instead of using that hack.

Legoktm added a comment.Oct 6 2013, 9:04 AM

(In reply to comment #7)

Ugh, $wgUser and varying config on request state.

Please use the SkinTemplateOutputPageBeforeExec to modify logopath instead of
using that hack.

[[m:Cunningham's Law]] strikes again! Thanks, your solution is much better.

Danny_B added projects: MediaWiki-User-Interface, MediaWiki-Internationalization, I18n.Jul 8 2016, 10:22 PM
Danny_B updated the task description. (Show Details)
Danny_B removed a subscriber: • wikibugs-l-list.
Qgil unsubscribed.Jul 29 2016, 2:37 PM
Harej moved this task from Incoming to Does This Need To Be an Extension? on the MediaWiki-extension-requests board.Feb 1 2018, 7:44 PM
Nikerabbit added a comment.Feb 8 2018, 2:46 PM

For https://nimiarkisto.fi/ I used BeforePageDisplay and CSS approach. Works okay to my knowledge as long as there is no frontend cache.

Yair_rand subscribed.Jul 2 2018, 9:43 PM

Current practice is to use Mediawiki:Common.css for this. See d:Mediawiki:Common.css, for example:

/* Language-specific logos */

#p-logo:lang(ar) a {
	background-image: url( //upload.wikimedia.org/wikipedia/commons/thumb/1/1f/Wikidata-logo-ar.png/140px-Wikidata-logo-ar.png ) !important;
}

#p-logo:lang(bn) a {
	background-image: url( //upload.wikimedia.org/wikipedia/commons/b/ba/Wikidata-logo-bn-156px.png ) !important;
}

#p-logo:lang(eo) a {
	background-image: url( //upload.wikimedia.org/wikipedia/commons/thumb/b/b9/Wikidata-logo-eo.svg/156px-Wikidata-logo-eo.svg.png ) !important;
}

#p-logo:lang(lfn) a {
	background-image: url(//upload.wikimedia.org/wikipedia/commons/thumb/a/aa/Wikidata-logo-lfn.svg/156px-Wikidata-logo-lfn.svg.png) !important;
}

#p-logo:lang(sk) a {
	background-image: url( //upload.wikimedia.org/wikipedia/commons/thumb/5/57/Wikidata-logo-sk.svg/156px-Wikidata-logo-sk.svg.png ) !important;
}

#p-logo:lang(uk) a {
	background-image: url(//upload.wikimedia.org/wikipedia/commons/thumb/a/ab/Wikidata-logo-uk.svg/156px-Wikidata-logo-uk.svg.png) !important;
}

#p-logo:lang(ur) a {
	background-image: url(//upload.wikimedia.org/wikipedia/commons/thumb/f/f3/Wikidata-logo-ur.svg/156px-Wikidata-logo-ur.svg.png) !important;
}
Nikerabbit merged a task: T146979: Allow varying the wiki logo (wgLogo/ wgLogoHD) by interface language.Feb 6 2021, 7:29 AM
Nikerabbit added subscribers: hoo, PokestarFan, Lydia_Pintscher and 3 others.
Winston_Sung subscribed.Mar 9 2022, 2:27 PM
Winston_Sung added a parent task: T303437: [Epic] Multivariant and multilingual wiki fixes and improvements.Mar 9 2022, 6:04 PM
Nikerabbit mentioned this in T273578: Wikis with language variants must override logo in Common.css.Apr 1 2022, 5:54 AM
Jdlrobson added subscribers: Func, Jdlrobson.Apr 1 2022, 2:55 PM

This has been fixed in T273578 (thanks @Func !)

The fix was meant for variants, but sites like Wikidata can define any language code in https://gerrit.wikimedia.org/g/operations/mediawiki-config/+/c25811667f0eb77a4904c4b31b5165337bcd1d19/wmf-config/InitialiseSettings.php#632

Jdlrobson closed this task as a duplicate of T273578: Wikis with language variants must override logo in Common.css.Apr 1 2022, 2:55 PM
Winston_Sung added a comment.Apr 3 2022, 3:53 PM

Would it be better to use "language" than "variant" for the key name?

Func added a comment.Apr 4 2022, 6:29 AM
In T22807#7826975, @Winston_Sung wrote:

Would it be better to use "language" than "variant" for the key name?

I think the "variant" here means "variants of logos", although they are varied by language code.

Md_Tanbir_Islam subscribed.Apr 4 2022, 8:01 AM

This will be a good thing. But it should only enable by users manually. If all site has it's fixed wiki logo then it will great. I suggest all users and editor to set their language preference for this action.

Winston_Sung added a comment.Apr 4 2022, 11:19 AM
In T22807#7827579, @Func wrote:

I think the "variant" here means "variants of logos", although they are varied by language code.

It is actually quite confusing as the documentation ( https://www.mediawiki.org/wiki/Special:MyLanguage/Manual:$wgLogos ) wrote "Supported variants".

Winston_Sung mentioned this in T303437: [Epic] Multivariant and multilingual wiki fixes and improvements.Apr 22 2022, 2:46 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL