| Kelson | |
| Sep 26 2009, 5:18 PM |
| F6125: DumpHTML_dir.patch | |
| Nov 21 2014, 10:50 PM |
| F6124: main.css.diff | |
| Nov 21 2014, 10:50 PM |
See the picture in attachment: the external links have a big padding before.
This does not happens on the online version.
For an unknown reason, replacing "padding: 0 npx" by "padding-rigth: npx" resolves the issue without impacting the online version (see the patch in attachment)
Version: unspecified
Severity: normal
Created attachment 6586
Modifications I have done to (partly) resolve the issue
Attached:
The problem rootcause is that in the SkinOffline.php the ltr/rtl class is not defined in the <body> CSS attribute. So please forget the previous patch, this is wrong.
Created attachment 7811
add rtl/ltr class to body of dumphtml
Fixing this is easy enough, see patch, but that leaves all the other "special" parts that a head can have. SkinOffline should be fixed to better reuse the <head> element of Skin.php I think.
Attached:
sumanah wrote:
Ariel, I think technically Tim Starling is the maintainer, so you could fling it to him.
sumanah wrote:
Derk-Jan, can I ask you to push this as a Gerrit merge request? Thanks.
Related URL: https://gerrit.wikimedia.org/r/60194 (Gerrit Change I3ca7102d40579b43af56e14b3f4bd8ddd33fb232)
Patch got merged - can this bug report be closed as RESOLVED FIXED or is more work required?
No reply to comment 11 - assuming this is FIXED.
Please reopen and elaborate which work is left, if that is not the case.