Page MenuHomePhabricator
Create Task
Maniphest T22867

Insert Link :Staus,Suggestions and link text are not refreshed in Safari
Closed, ResolvedPublic
Actions

Description

Author: wikibugs

Description:
Reporting against the build hosted on Staging environment. (http://prototype.wikimedia.org)

Steps to reproduce :

  1. Start editing a page in Safari
  2. Click 'Insert Link' icon <<Dialog is opened >>
  3. Enter 'A' in Page title text box

<< Status icon become orange instantly. Link suggestions appear later (after 2-3 sec)>>

  1. Now select a page from suggestion list

<< Status icon become green as expected >>

  1. Now bring cursor to end of page name
  2. Click backspace and delete a character

<< Status icon remain green even though there is no page with it>>

  1. Repeat step 6 and check status icon

<<Progress status is not shown. New list does not appear. Also the link text is not changed as user change the Page title >>

Expected Outcome:

  1. Progress status icon shall be displayed as user change the Page Title
  2. User shall be presented with new link suggestions as user change Page Title
  3. Status icon shall be changed accordingly as new page name is given

Other Observations::
This work fine in Firefox.

Test Environment ::
Browser (User-Agent): Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US) AppleWebKit/530.19.2 (KHTML, like Gecko) Version/4.0.2 Safari/530.19.1
Javascript: Enabled
Cookies Enabled: Enabled
Java Enabled: Enabled
Screen Width x Height: 1280 x 800
Screen Color Depth: 32
Window Width: 574 (44.8% of 1280)
Window Height: 353 (44.1% of 800)

Version: unspecified
Severity: normal
OS: Windows Vista
Platform: PC
URL: http://prototype.wikimedia.org

Details

Reference
bz20867

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:53 PM
• bzimport added a project: MediaWiki-extensions-UsabilityInitiative.
• bzimport set Reference to bz20867.
• bzimport created this task.Sep 29 2009, 7:42 AM
• TrevorParscal added a comment.Jan 26 2010, 1:14 AM

This has been resolved.

• bzimport added a comment.Jan 28 2010, 9:43 AM

wikibugs wrote:

Wiki_r61577_2010-01-28_Link.pdf

Attached:

Wiki_r61577_2010-01-28_Link.pdf77 KBDownload

• bzimport added a comment.Jan 28 2010, 9:44 AM

wikibugs wrote:

(In reply to comment #2)

Created an attachment (id=7041) [details]
Wiki_r61577_2010-01-28_Link.pdf

Please refer the attachment. Expected outcome number 01 is not resolved.

Catrope added a comment.Jan 28 2010, 5:29 PM

(In reply to comment #3)

(In reply to comment #2)

Created an attachment (id=7041) [details] [details]
Wiki_r61577_2010-01-28_Link.pdf

Please refer the attachment. Expected outcome number 01 is not resolved.

Which browser does this happen in? Works fine in Firefox but I suspect IE and/or Webkit may not update the existence status when you press backspace.

Catrope added a comment.Jan 28 2010, 5:30 PM

(In reply to comment #4)

(In reply to comment #3)

(In reply to comment #2)

Created an attachment (id=7041) [details] [details] [details]
Wiki_r61577_2010-01-28_Link.pdf

Please refer the attachment. Expected outcome number 01 is not resolved.

Which browser does this happen in? Works fine in Firefox but I suspect IE
and/or Webkit may not update the existence status when you press backspace.

Never mind, I'm an idiot. Obviously this is Safari, should've read the bug title :)

• bzimport added a comment.Feb 2 2010, 9:30 AM

wikibugs wrote:

Wiki_r61584_2010-02-02_InsertLinkReturn.pdf

Tried the below ,

  1. Select a page from suggestion list
  2. Insert the link
  3. Click on insert link again.
  4. The page status indicator shows as the page is exists.

This showed in all the browsers

Attached:

Wiki_r61584_2010-02-02_InsertLinkReturn.pdf34 KBDownload

• bzimport added a comment.Feb 3 2010, 3:22 PM

amiller1 wrote:

Fixed both the reported issue and the separate issue identified in Comment 6 with r61894 and r61932 respectively. Please check both issues again.

• bzimport added a comment.Feb 5 2010, 8:08 AM

wikibugs wrote:

Wiki_r59858_2010-02-05_PageStatusLink.pdf

Reporting against Babaco Release : test.wikipedia.org (version r59858)

Tried the below ,

  1. Select a page from suggestion list
  2. Click on Cancel
  3. Click on insert link again.
  4. The pop-up shows the valid link but the page status indicator is missing.

Attached:

Wiki_r59858_2010-02-05_PageStatusLink.pdf53 KBDownload

• bzimport added a comment.Feb 5 2010, 8:09 AM

wikibugs wrote:

(In reply to comment #8)

Created an attachment (id=7075) [details]
Wiki_r59858_2010-02-05_PageStatusLink.pdf

Reporting against Babaco Release : test.wikipedia.org (version r59858)

Tried the below ,

  1. Select a page from suggestion list
  2. Click on Cancel
  3. Click on insert link again.
  4. The pop-up shows the valid link but the page status indicator is missing.

Therefore Re-open the bug

• bzimport added a comment.Feb 5 2010, 4:49 PM

amiller1 wrote:

Didn't account for that case. Addressed by simply triggering the change event on the text box when it's displayed ensuring that the status indicator will be up to date every time the dialog is opened. Fixed in r62033.

• bzimport added a comment.Mar 12 2010, 9:49 AM

wikibugs wrote:

Verified and closed

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL