Michael.Keppler wrote:

patch for HEAD

The problem is located in the code for the template cache table. When a
template is used multiple times on the same page, then the following happens,
when the template is first parsed:
a) The output text is set to the article content.
b) The line start (anything before the template pattern) is prepended to the
text.
c) The text is stored in the template cache.
As one can see, the prepending of the line start happens too early as the line
start of the first template occurence will be used as content of the second
template occurence this way (and the linestart variable contains a linebreak in
the example of this bug).

So we need to reorder c) and b). The attached patch does just this. The
linestart of the template is only prepended to the output after the cache has
been stored.

Attached:

Michael.Keppler wrote:

changed title to better describe the problem

Michael.Keppler wrote:

*** Bug 2116 has been marked as a duplicate of this bug. ***

Michael.Keppler wrote:

patch for REL14

same patch for REL14 as for HEAD

Attached:

gangleri wrote:

Feedback:

Thanks Michael for your attachment. It is active at
http://jadesukka.homelinux.org:8180/betawiki/

http://jadesukka.homelinux.org:8180/mediawiki15c/index.php?title=Betawiki:Rendering_of_templetes_01&action=purge
LOOKS GREAT!

What I experienced with:
http://jadesukka.homelinux.org:8180/mediawiki15c/index.php?title=Betawiki:Users&action=purge
http://jadesukka.homelinux.org:8180/mediawiki15c/index.php?title=Betawiki:Users_%28fix%29&action=purge
http://jadesukka.homelinux.org:8180/mediawiki15c/index.php?title=Betawiki:Users_%28alternate%29&action=purge
With some efforts ALL are FIXED.

There is a problem with Windows XP Mozilla Firefox and Java:

When I hit two times return and (make a preview | click on a Java button in the
Romanian interface to generate special characters) ONLY ONE line ( is inserted |
WILL "SURVIVE" ). Most of the time I avoid this inserting some new lines and
deleting them after just counting the number of new lines I REALY need.

When you look at the HISTORY of the last three mentioned pages you will see that
there are some ODD versions. I noticed that your patch MAY relate to the
mentioned Java bug.

What I did to fix
http://jadesukka.homelinux.org:8180/mediawiki15c/index.php?title=Betawiki:Users_%28alternate
: I commented the line containing "GangleriBot". Then I made a preview. After
this I hit some new lines and made the Preview a few times again until I was
shure that the "blank characters" where "REAL NEW LINES" (whatever this means).

Maybe you are more skilled to analyse the code of the pages in the history and
find out "WHAT ( IS | WAS ) THERE". Maybe it would be an improuvment to be able
to distinguish between ( spaces | tabs | different new line variants in
Linux|Windows|whatever ). Similar to what you can do in TextPad, Word etc.

There shoud be a bug report about beeing able to see changes in "white space"
(?) in history|diff.

Best regards Reinhardt [[user:gangleri]]

Michael.Keppler wrote:

testcase for parsertests

This test case reproduces the bug. Please paste complete attachment content at
the end of your parsertests.txt file.

Without the patch, the test fails because there is an unwanted "<p></p>" in
line 7 of the parser output.

With the patch applied, this unwanted paragraph (caused by a the newline
wrongly taken from the linestart variable) is removed and the test succeeds.

Attached:

wegge wrote:

Patch comitted to REL1_4 and HEAD.

• Bug 1146 has been marked as a duplicate of this bug. ***