Author: yonidebest
Description:
In FF, when i click the button that allows me to hide multiple revisions, the action preformed (as shown in url) is "action=revisiondelete". This works.
In IE8, when i click said button, the action preformed is "action=הצגת/הסתרת הגרסאות שנבחרו" (which is the text that is written on the button), and the action fails. I guess that in IE, "value" means caption, instead of the "value" property defined in the Button element.
Version: unspecified
Severity: normal
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| HistoryAction: Remove use of action=historysubmit hack | mediawiki/core | master | +18 -11 |
yonidebest wrote:
Also, another problem (perhaps related), although in IE6: the diff button seems to not work either. in URL i can see there are two "action" passes (i think there should be no action passes).
yonidebest wrote:
(In reply to comment #2)
Is this in the beta version, or the regular skin?
regular monobook skin.
http://msdn.microsoft.com/en-au/library/ms535211(VS.85).aspx
"When the BUTTON element is submitted in a form, the value depends on the current document compatibility mode. In IE8 mode, the value attribute is submitted. In other document modes and earlier versions of Internet Explorer, the innerText value is submitted."
Reassigned to me.
yonidebest wrote:
Tim, the fix works in IE8. In IE6 there is a problem (mentioned in comment #1) with the diff button: seems like it acts like the revisiondelete button -- wrong "action"?
yonidebest wrote:
Forget it. IE6 is obsolete - I closed the bug as it was fixed in IE8.
Change 858436 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/core@master] HistoryAction: Remove use of action=historysubmit hack
Change 858436 merged by jenkins-bot:
[mediawiki/core@master] HistoryAction: Remove use of action=historysubmit hack