Page MenuHomePhabricator

lsearchd should "exec java ..." to optimize the number of running daemon
Closed, DeclinedPublic

Description

Author: anon.hui

Description:
lsearchd should "exec java ..." to optimize the number of running daemon like this,

lsearchd:

 #!/bin/sh
 jardir=`dirname $0` # put your jar dir here!
-java -Djava.rmi.server.codebase=file://$jardir/LuceneSearch.jar -Djava.rmi.server.hostname=$HOSTNAME -jar $jardir/LuceneSearch.jar $*
+exec java -Djava.rmi.server.codebase=file://$jardir/LuceneSearch.jar -Djava.rmi.server.hostname=$HOSTNAME -jar $jardir/LuceneSearch.jar $*

It also help handling lsearchd daemon using "start-stop-daemon --stop" more easier.


Version: unspecified
Severity: enhancement

Details

Reference
bz21031

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:50 PM
bzimport set Reference to bz21031.
bzimport added a subscriber: Unknown Object (MLST).

anon.hui wrote:

Should also use "$@" rather than $*, to pass arguments,

exec java -Djava.rmi.server.codebase=file://$jardir/LuceneSearch.jar -Djava.rmi.server.hostname=$HOSTNAME -jar $jardir/LuceneSearch.jar "$@"

sumanah wrote:

Anon Sricharoenchai, can you tell us whether your patch still works against current trunk, and attach it as a diff? Thanks!

sumanah wrote:

Anon, instructions for attaching a patch as a diff:

https://www.mediawiki.org/wiki/Patch#Posting_a_patch

[Merging "MediaWiki extensions/Lucene Search" into "Wikimedia/lucene-search2", see bug 46542. You can filter bugmail for: search-component-merge-20130326 ]

I don't see any patch here. Removing keyword.

Wont be fixing this, lsearchd has reached its end of life.