Page MenuHomePhabricator

Some wikis have missing logo images on secure server
Closed, ResolvedPublic

Description

Author: artificial

Description:
This is an extension to bug 20723 -- I found a few more affected wikis where the logo image is linked using a relative path which doesn't work via the secure server.

Here are the links to the wikis and the full paths of the images.

Bulgarian Wikibooks:
https://secure.wikimedia.org/wikibooks/bg/wiki/
http://bg.wikibooks.org/
http://upload.wikimedia.org/wikibooks/bg/b/bc/Wiki.png

Hebrew Wikibooks:
https://secure.wikimedia.org/wikibooks/he/wiki/
http://he.wikibooks.org/
http://upload.wikimedia.org/wikibooks/he/b/bc/Wiki.png

Latin Wiktionary:
https://secure.wikimedia.org/wiktionary/la/wiki/
http://la.wiktionary.org/
http://upload.wikimedia.org/wiktionary/la/b/bc/Wiki.png

Neapolitan Wikipedia:
https://secure.wikimedia.org/wikipedia/nap/wiki/
http://nap.wikipedia.org
http://upload.wikimedia.org/wikipedia/nap/b/bc/Wiki.png


Version: unspecified
Severity: normal

Details

Reference
bz21068

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:52 PM
bzimport set Reference to bz21068.

Let's take a look...

<div class="portlet" id="p-logo">
<a style="background-image: url(/upload/b/bc/Wiki.png);"

Yep. Some $wgLogo entries need to be updated to use full URLs to the uploaded logo; ('$stdlogo' will do fine for those uploaded locally with name Wiki.png, that'll just be the full URL version of that). On the regular interfaces these work because there are compatibility redirects in the web server config, but for secure that's just a bogus link.

Check also the ones using the old hardcoded logos like /images/wiki-en.png but I think they're fine. (shared /images path on secure.wm.o)

n-roeser wrote:

German Wikipedia is also affected. For example, https://secure.wikimedia.org/wikipedia/de/wiki/Wikipedia:Hauptseite contains the following markup:

<div class="portlet" id="p-logo">

		<a style="background-image: url(http://upload.wikimedia.org/wikipedia/de/b/bc/Wiki.png);" href="/wikipedia/de/wiki/Wikipedia:Hauptseite" title="Hauptseite"></a>

</div>

n-roeser wrote:

I was told that I obviously misunderstood comment 0, and that this bug is about images not being *displayed*. I interpreted it as images being loaded via HTTP instead of via HTTPS when using the secure server. That issue is tracked in bug 18496.

Sorry for the bugspam. :-(