Page MenuHomePhabricator

Make Navigable TOC collapsible
Closed, ResolvedPublic

Description

NTOC and ProofreadPage on a netbook screen

When using the ProofreadPage extension together with the enhanced editing toolbar, the editing window gets very small. It would be nice if there was a button to collapse the Navigable TOC so the edit window becomes larger.

Attached is a screen shot of how this looks like on my netbook (This is r57791 of the UsabilityInitiative extension)


Version: unspecified
Severity: normal

Attached:

ntoc-small-screen.png (600×977 px, 152 KB)

Details

Reference
bz21226

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:50 PM
bzimport set Reference to bz21226.

Seems you're reading our minds, we were already planning on doing this. Assigning to Adam since he's probably gonna be implementing this.

This feature is now live on the prototype wikis.

Hmm, doesn't seem to work on e.g. http://prototype.wikimedia.org/d-en/index.php?title=Taliban&action=edit .
I tested it on my local wiki, and by setting

$wgNavigableTOCCollapseEnable = true;

in LocalSettings.php I got the button to appear, but it seems broken. When clicking it, the NTOC text disappears, but the edit area is not resized. The button also disappears, so there is no way to get the text back.

Tested with the following settings:
$wgDefaultUserOptions['skin'] = 'vector';
$wgDefaultUserOptions['usenavigabletoc'] = 1;
$wgDefaultUserOptions['wikieditor-highlight'] = 1;
$wgDefaultUserOptions['wikieditor-preview'] = 1;
$wgDefaultUserOptions['usebetatoolbar'] = 1;
$wgDefaultUserOptions['usebetatoolbar-cgd'] = 1;
$wgNavigableTOCCollapseEnable = true;
$wgVectorUseSimpleSearch = true;
$wgEnableJS2system = true;
// the following are old IIRC
$wgEditToolbarGlobalEnable = true;
$wgEditToolbarCGDGlobalEnable = true;
$wgNavigableTOCGlobalEnable = true;
$wgEditToolbarUserEnable = false;

phase3 r59072, UsabilityInitiative r59048 (i.e. from today)

Tested using Iceweasel 3.0.6 on Debian Lenny.

(In reply to comment #3)

Hmm, doesn't seem to work on e.g.
http://prototype.wikimedia.org/d-en/index.php?title=Taliban&action=edit .
I tested it on my local wiki, and by setting

$wgNavigableTOCCollapseEnable = true;

in LocalSettings.php I got the button to appear, but it seems broken. When
clicking it, the NTOC text disappears, but the edit area is not resized. The
button also disappears, so there is no way to get the text back.

Yes, the collapsing of the NTOC is sort of broken at the moment (was much worse before I took a stab at it); this is a known issue that was probably caused by one of Trevor's restructurings, so either he or Adam should fix it. CCing Trevor for this reason.

This has been fixed, a while ago actually. Say, around r53970.