Page MenuHomePhabricator

WikiEditor does not show if TOC is set to false as of r58851
Closed, ResolvedPublic

Description

Author: buzz

Description:
Not sure if svn is supposed to be kept "in a working state", so sorry if this bug report is something known and planned to be fixed.

I updated to the latest SVN HEAD version of the extension today (r58851). I changed the configuration to match the new array system (Still undocumented but I assume this is on your todo list). However, the toolbar didn't appear.

Seems that I have to enable the table of contents, or the wikieditor doesn't appear.

doesnt work:
$wgWikiEditorModules = array(
'toc' => array( 'global' => false, 'user' => false ),
'toolbar' => array( 'global' => true, 'user' => false ),
);

works:
$wgWikiEditorModules = array(
'toc' => array( 'global' => true, 'user' => false ),
'toolbar' => array( 'global' => true, 'user' => false ),
);


Version: unspecified
Severity: normal

Details

Reference
bz21459

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:52 PM
bzimport set Reference to bz21459.

(In reply to comment #0)

Not sure if svn is supposed to be kept "in a working state", so sorry if this
bug report is something known and planned to be fixed.

Yes, SVN HEAD is pretty broken at the moment, we expect this to be better around the end of the week.

I updated to the latest SVN HEAD version of the extension today (r58851). I
changed the configuration to match the new array system (Still undocumented but
I assume this is on your todo list).

Yes, sorry about thiat.

However, the toolbar didn't appear.

Seems that I have to enable the table of contents, or the wikieditor doesn't
appear.

doesnt work:
$wgWikiEditorModules = array(

'toc' => array( 'global' => false, 'user' => false ),
'toolbar' => array( 'global' => true, 'user' => false ),

);

works:
$wgWikiEditorModules = array(

'toc' => array( 'global' => true, 'user' => false ),
'toolbar' => array( 'global' => true, 'user' => false ),

);

Interesting. I'll debug this, but it may have to wait for a bit while we're restructuring other parts.

buzz wrote:

Sorry to report but this is still not working for me.

I just updated the extension to r58992, with the following config

require_once("extensions/UsabilityInitiative/WikiEditor/WikiEditor.php");
$wgWikiEditorModules = array(
'toc' => array( 'global' => true, 'user' => false ),
'toolbar' => array( 'global' => true, 'user' => false ),
);

I am getting no new editor at all. Also in my user prefs I get the options

	 Enable navigable table of contents
	 Enable enhanced editing toolbar
	 Enable dialogs for inserting links, tables and more

but surely I should get no preferences at all with my config above?

My Mediawiki version is r58824.

desiree.i.gennaro wrote:

This is still not working for me either. I have just updated the extension to r59186.

Fixed in r60316 and r60317. Note that the "Enable dialogs for inserting links, tables and more" will still be shown if the toolbar is globally enabled.

desiree.i.gennaro wrote:

The WikiEditor is still not working for me in r60451.

(In reply to comment #6)

The WikiEditor is still not working for me in r60451.

Not working how?

desiree.i.gennaro wrote:

(In reply to comment #7)

(In reply to comment #6)

The WikiEditor is still not working for me in r60451.

Not working how?

The WikiEditor is not loading. Only the standard editing toolbar.

(In reply to comment #8)

(In reply to comment #7)

(In reply to comment #6)

The WikiEditor is still not working for me in r60451.

Not working how?

The WikiEditor is not loading. Only the standard editing toolbar.

Could you:

  1. tell us what your $wgWikiEditorModules is set to (if set)
  2. try commenting out your $wgWikiEditorModules (if set) and see if that fixes the problem
  3. tell us whether you're logged in or not when viewing the edit form, and

3a) if logged in, tell us which checkboxes in My preferences -> Editing -> Experimental are checked

desiree.i.gennaro wrote:

(In reply to comment #9)

(In reply to comment #8)

(In reply to comment #7)

(In reply to comment #6)

The WikiEditor is still not working for me in r60451.

Not working how?

The WikiEditor is not loading. Only the standard editing toolbar.

Could you:

  1. tell us what your $wgWikiEditorModules is set to (if set)
  2. try commenting out your $wgWikiEditorModules (if set) and see if that fixes

the problem

  1. tell us whether you're logged in or not when viewing the edit form, and

3a) if logged in, tell us which checkboxes in My preferences -> Editing ->
Experimental are checked

1)default in WikiEditor.php
$wgWikiEditorModules = array(
'highlight' => array( 'global' => false, 'user' => true ),
'preview' => array( 'global' => false, 'user' => true ),
'publish' => array( 'global' => false, 'user' => true ),
'toc' => array( 'global' => false, 'user' => true ),
'toolbar' => array( 'global' => false, 'user' => true ),
'templateEditor' => array( 'global' => false, 'user' => true ),
);

I have also tried the settings noted above:

$wgWikiEditorModules = array(

'toc' => array( 'global' => true, 'user' => false ),
'toolbar' => array( 'global' => true, 'user' => false ),

);

  1. Still not working
  1. Yes, I am logged in.

3a) My preferences -> Editing -> Experimental
"Enable enhanced editing toolbar"

I am receiving the following error on the page when editing:
Error: 'mw' is undefined

Hope this helps.

desiree.i.gennaro wrote:

In addition to above:

1 continued) I have also tried the settings noted in the README file:

$wgWikiEditorModules = array(
'highlight' => array( 'global' => false, 'user' => true ),
'preview' => array( 'global' => false, 'user' => true ),
'toc' => array( 'global' => false, 'user' => true ),
'toolbar' => array( 'global' => false, 'user' => true ),
);

(In reply to comment #10)

I am receiving the following error on the page when editing:
Error: 'mw' is undefined

Hope this helps.

You need to update your version of MediaWiki. Every now and then we change stuff in MediaWiki core and update the UsabilityInitiative extension to rely on those changes.

buzz wrote:

Yeh it sounds like you are not running the latest version from svn of mediawiki. I had the same problem that the toolbar wasn't appearing at all, and a svn up quickly fixed it.

desiree.i.gennaro wrote:

I have upgraded to the latest version of MW 1.16alpha and the toolbar is showing now, but none of the buttons work [r61050].

desiree.i.gennaro wrote:

[r61338] no longer shows the toolbar.