Page MenuHomePhabricator

Toolbar buttons insert text on top in IE
Closed, ResolvedPublic

Description

Author: churchill95

Description:
Toolbar bugs on enwiki:

  1. When I highlight text and then bold/italicize, it inserts the bold/italicized text somewhere else in the doc (vs simply inserting the markup around the text).
  1. The toolbar links (eg advanced, help) don't expand anything when clicked. I've tried refreshing the window but that doesn't help.

Both these are working fine on dewiki in comparison.


Version: unspecified
Severity: blocker
OS: Windows XP
Platform: Macintosh

Details

Reference
bz21492

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:54 PM
bzimport set Reference to bz21492.

(In reply to comment #0)

Toolbar bugs on enwiki:

  1. When I highlight text and then bold/italicize, it inserts the

bold/italicized text somewhere else in the doc (vs simply inserting the markup
around the text).

  1. The toolbar links (eg advanced, help) don't expand anything when clicked.

I've tried refreshing the window but that doesn't help.

Number 2 has been fixed.

  • Bug 21539 has been marked as a duplicate of this bug. ***

amiller1 wrote:

Roan, when I commented out the call to $(this).focus() on line 87 of
jquery.textSelection.js, it mostly fixes problem number one in IE7. The text is
inserted at the correct location, but it still jumps the cursor to a seemingly
arbitrary location after the insert is preformed.

  • Bug 21567 has been marked as a duplicate of this bug. ***

Reports that this is not fixed on dewiki, see bug 21567. Will investigate.

Since we are no longer using a textarea, this has been solved.

(In reply to comment #7)

Since we are no longer using a textarea, this has been solved.

You'd be surprised: http://www.mediawiki.org/wiki/User:Catrope/Bizarre_browser_bugs#Loss_of_selection_in_content-editable_iframe

Changing resolution to FIXED, because that's basically what we did by introducing the iframe.