Page MenuHomePhabricator

Support full-width commas for pipe trick
Closed, ResolvedPublic

Description

full-width commas

It doesn't support full-width commas.


Version: 1.16.x
Severity: normal

attachment commas.diff ignored as obsolete

Details

Reference
bz21660

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:53 PM
bzimport set Reference to bz21660.

conrad.irwin wrote:

Fixed in r62076

EN.WP.ST47 wrote:

Do it without adding another regex. Also includes parser tests.

I don't see any reason why we can't fix this just like bug 30149. I add some parser tests as well (which pass) and fix a problem with one of the parser tests I wrote for 30149 (there were some spaces that shouldn't have been, it still passed but some possibilities weren't covered).

Attached:

EN.WP.ST47 wrote:

See gerrit #8696

That change was deployed, so marking resolved. Please reopen if you test and find a problem.