Page MenuHomePhabricator

No recent changes RSS/Atom feeds on Recent Changes page
Closed, ResolvedPublic

Description

Author: buzz

Description:
patch to not exclude recent changes from rss feed

Comment in OutputPage.php states

Recent changes feed should appear on every page (except recentchanges, that would be redundant).

making me think that at some point, recent changes outputted it's own RSS feed. However, I am not sure, but currently there is no RSS feed for recent changes on the recent changes page.

Attached patch removed the check to see if we are on the recent changes page and so adds the recent changes feed to all pages.


Version: 1.16.x
Severity: normal

Attached:

Details

Reference
bz21738

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:46 PM
bzimport set Reference to bz21738.
bzimport added a subscriber: Unknown Object (MLST).

Cf bug 14500 and r36212 where I removed it.

(In reply to comment #1)

Cf bug 14500 and r36212 where I removed it.

From that bug: there is a <link rel="alternate"> tag pointing to the RC feed on every page. This shows up as e.g. an RSS icon in Firefox's address bar.

I suppose it's slightly off-putting to people on older browsers who don't get a UI hint like in Firefox, but still want the URI to the site RSS feed.

buzz wrote:

i made my patch because I got no UI hint in firefox on the recent changes page. Am i missing something ?
(And i saw nothing in the headers about rss on the recent changes page)

(In reply to comment #5)

For example

http://en.wikipedia.org/wiki/Special:RecentChanges

where is the feed?

Ha, apparently it's now missing both. Confirmed this on trunk as well.

buzz wrote:

yeh as i said in my bug. "but currently there is no RSS feed for recent changes
on the recent changes page." :). my patch fixes this, or i guess we could just revert 36212.
something must have changed elsewhere ?

bugs wrote:

The problem is not r36212, and also the patch is not the correct one. Special:RecentChanges already have syndication links, it is set in SpecialRecentchanges::webOutput() with a $wgOut->setSyndicated() call.

Note that this bug was introduced in 1.16-svn. If you look deeper, you will find that Special:UnusedCategories and possibly others are also missing syndication links.

The real problem here was introduced in r57119, which made $wgOut->setSyndicated() into a no-op.

buzz wrote:

aah. I had actually looked at that patch before, and not noticed that. Well spotted. Thanks

CCing Andrew since it's his fault :)