Page MenuHomePhabricator

Download video option
Closed, ResolvedPublic

Description

This is mostly an issue for the image webserver, but of course for functionality to be provided by the mwEmbed videoplayer.

I was thinking that for the download option in the menu to be really useful, it should actually download (doesn't do that on Safari, just embeds in an empty window). I was thinking we could add a download option to the image webservers, that could be triggered by URL. It would set Content-Disposition HTTP header in the URL response with the option "attachment; filename=test.ogg" and that should force browsers to actually download the file.


Version: unspecified
Severity: enhancement

Details

Reference
bz21853

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:53 PM
bzimport set Reference to bz21853.

mdale wrote:

I agree it would be a nice feature to have. Should it be added as a php script or could in theory be some fancy .htaccess type thing that checks for a particular argument and then sets the content-disposition. The php version could be done pretty quickly as there are lots of simulating http-ranged requests with content-disposition header control php scripts out there for doing exactly that.

Not sure who the primary upload server maintainer is. Ariel ?

  • Bug 26956 has been marked as a duplicate of this bug. ***

Bryan.TongMinh wrote:

Yeah, Ariel would be a good guess.

It is best if the server just sets the header, by using a special uri variant. PHP scripts don't work for the larger files, and don't run on the downloadserver.

Actually, this was already filed as bug 25695.

This was about integrating the functionality in mwEmbed.

mdale wrote:

*** Bug 30563 has been marked as a duplicate of this bug. ***

jgerber wrote:

download links have the html5 download attribute now,
this should fix this issue in new browsers.