Page MenuHomePhabricator

Patch that fixes multiple bugs for DynamicPageList (intersection)
Closed, ResolvedPublic

Description

Patch that fixes several bugs, and adds a couple new features

I've been playing around with DynamicPageList (intersection) recently, and made a number of modifications, fixing several open bugs in the process. This is a patch that does the following:

I hope this is useful.

Cheers,
Bawolff


Version: unspecified
Severity: enhancement

Attached:

Details

Reference
bz21963

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:48 PM
bzimport set Reference to bz21963.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 6909
patch with commented debug line removed, and whitespace changes ignored.

attachment intersectionPatch.patch ignored as obsolete

Created attachment 6910
redo the requested version of patch that has no whitespace changes (apperently i screwed up the last one somehow)

Attached:

pdhanda wrote:

Is it possible to display images using the DynamicPageList? So far I only see the article title text which looks a little weird in gallery format.

with this patch try:
<DynamicPageList>
namespace=image
mode=gallery
count=5
</DynamicPageList>

Any DPL results that are not images will be displayed as a text-only gallery item, which admittedly looks a tad weird, so restricting the namespace to file/image is probably a good idea if using gallery mode.

pdhanda wrote:

Ok i did some testing on my local install and checked in Bawolff's fix. Would be nice if someone else could also do some testing in case i missed some scenarios :)
-p

I had tested it and given some feedback on IRC a week or so ago. Looks like those changes were added in this latest patch.

-need-review +reviewed

Ah, didn't see the checkin already. Marking this FIXED as of r60800.