API: fix for change tag queries
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• bzimport
	Jan 6 2010, 1:05 PM

Description

Author: matthew.britton

Description:
Per http://www.mediawiki.org/wiki/Special:Code/MediaWiki/58399#c4958 there is a problem with the change tagging queries introduced in r58399.

"This omits the FORCE INDEX on the change_tag table when tag filtering is being done (i.e. with rctag=foo). Without this index, there's a chance this module will crash the site, like the UI version did before r49068. Presumably rvtag and letag are also affected, but I haven't tested them."

Obviously I don't want code I wrote to crash the site, but I'm not 100% sure how to fix this.

Version: unspecified
Severity: normal

Details

Reference: bz22032

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:53 PM

• bzimport added a project: MediaWiki-Action-API.

• bzimport set Reference to bz22032.

• bzimport created this task.Jan 6 2010, 1:05 PM

matthew.britton wrote:

patch against r61457

Attached patch should fix this; specifies the appropriate index for recentchanges, revisions, usercontribs and logevents queries, also fixes an unrelated PHP notice in usercontribs.

Only thing I'm not sure about is on CodeReview for r58399 Roan claims the index has a different name on Wikimedia wikis, in which case this won't work; is that still the case?

Attached:

change-tags-fix.patch5 KBDownload

r61957

	F6240: change-tags-fix.patch
	Nov 21 2014, 10:53 PM

API: fix for change tag queriesClosed, ResolvedPublicActions

Description

Details

Event Timeline

API: fix for change tag queries
Closed, ResolvedPublic
Actions