Page MenuHomePhabricator
Create Task
Maniphest T24034

Use wfClientAcceptsGzip() in wfGzipHandler
Closed, ResolvedPublic
Actions

Description

Use wfClientAcceptsGzip() in wfGzipHandler

wfGzipHandler should use wfClientAcceptsGzip() instead of reimplement it itself.
Attached patch does it, and removes the $wgUseGzip check on wfClientAcceptsGzip() since HTMLFileCache (the only wfClientAcceptsGzip() user) already checked that before calling it. This way $wgUseGzip stays applying only for file cache, and $wgDisableOutputCompression for output handler.

Version: 1.16.x
Severity: enhancement

attachment bug 22034.patch ignored as obsolete

Details

Reference
bz22034

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:53 PM
• bzimport added a project: MediaWiki-General.
• bzimport set Reference to bz22034.
• bzimport added a subscriber: Unknown Object (MLST).
Platonides created this task.Jan 6 2010, 6:35 PM
siebrand added a comment.Jan 9 2010, 6:10 PM

Applied in r60864. Thanks.

siebrand added a comment.Jan 9 2010, 7:15 PM

Reverted in r60871. Causes PHP Notice: Undefined index: HTTP_ACCEPT_ENCODING in GlobalFunctions.php on line 1175

Platonides added a comment.Jan 9 2010, 7:19 PM

Second version of the patch

Attached:

bug_22034_(2nd_version).patch1 KBDownload

Platonides added a comment.Jan 14 2010, 4:40 PM

Applied on r61054.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL