Check return value of hook SpecialContributionsBeforeMainOutput in SpecialContributions
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Wikinaut
	Jan 8 2010, 7:44 AM

Description

The return value of hook SpecialContributionsBeforeMainOutput in SpecialContributions is not checked. This means, that external users using this hook can currently not return a false value in order to abort the main processing (rendering the form and list of contribution).

I added an if() statement - see patch - in conformity to similar hooks in other modules.

With the patch, "false" stopps the processing.

Version: 1.16.x
Severity: normal

Details

Reference: bz22051

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:54 PM

• bzimport added a project: MediaWiki-Special-pages.

• bzimport set Reference to bz22051.

• bzimport added a subscriber: Unknown Object (MLST).

Wikinaut created this task.Jan 8 2010, 7:44 AM

Created attachment 6938
Patch

Attached:

x.diff485 BDownload

Fixed in r60848.

	F6292: x.diff
	Nov 21 2014, 10:54 PM

Check return value of hook SpecialContributionsBeforeMainOutput in SpecialContributionsClosed, ResolvedPublicActions

Description

Details

Event Timeline

Check return value of hook SpecialContributionsBeforeMainOutput in SpecialContributions
Closed, ResolvedPublic
Actions