Page MenuHomePhabricator

Special:Interwiki's description on Special:SpecialPages should not say "and edit" for users not having "interwiki" right
Closed, ResolvedPublic

Description

diff patch

In http://svn.wikimedia.org/viewvc/mediawiki?view=rev&revision=59347 the second parameter (restriction) is missing and should be set to "interwiki". Then the Special Page extension is only shown and executed for users having that permission.


Version: unspecified
Severity: normal
URL: http://www.mediawiki.org/wiki/Extension:Interwiki

attachment x.diff ignored as obsolete

Details

Reference
bz22221

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:53 PM
bzimport set Reference to bz22221.

Created attachment 7003
patch

Attached:

"interwiki" right allows users to edit entries, users without that right can still access the page to see the list of prefixes. Adding this restriction to the constructor would remove the page from Special:SpecialPages even for users able to access it.

(In reply to comment #2)

"interwiki" right allows users to edit entries, users without that right can
still access the page to see the list of prefixes.

Okay, you are right in this respect.

I investigated and found a remaining problem (which puzzled me first). This is the text text on Special:Pages still saying for all users "View and edit interwiki data" - which is incorrect for those majority of users without "interwiki" permission.

For such users the text need to be "View interwiki data" (without "and edit").

In order not to make it too complicate I suggest:

to change the text "View and edit interwiki data" to something neutral like --> "Interwiki data"