Page MenuHomePhabricator

Unrecognized value for parameter blfilterredir
Closed, DeclinedPublic

Description

Probably will get round to fixing this, but logging it as I can't atm

Supplying blfilterredir= barfs, should just take that as all (ie default)


Version: unspecified
Severity: minor
URL: http://en.wikipedia.org/w/api.php?action=query&list=backlinks&bltitle=Greatest+Hits+%E2%80%93+Volumen+1993%E2%80%932003&bllimit=max&blnamespace=0&blredirect&blfilterredir=

Details

Reference
bz22237

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:54 PM
bzimport set Reference to bz22237.

This is a deeper problem with the param validation code in ApiBase: what should happen to an invalid value? Maybe there should be a boolean flag in the getAllowedParams() array that specifies whether it's OK to fall back to the default in this case (if not, we'll go back to the old behavior and throw an error).

OTOH, it's a bot API, our clients are responsible for and perfectly capable of supplying valid requests.

john wrote:

I don't think this is worth throwing in a fallback option for the parameter. Roan is right, bot programmers should be smart enough to pass the right value to the API.