Page MenuHomePhabricator

LocalSettings.php $wgHTTPProxy should take default value from environment variable $http_proxy if present
Closed, ResolvedPublic

Description

I suggest an improvement so that the variable $wgHTTPProxy - which is needed for curl calls for example for uploading files from external urls - is initialized from environement variable $http_proxy (if present).

Diff/Patch follows


Version: 1.16.x
Severity: normal
URL: http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/HttpFunctions.php?view=markup

Details

Reference
bz22268

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:55 PM
bzimport set Reference to bz22268.

Created attachment 7016
diff / patch

Attached:

Suggest WONTFIX. Just because an environment variable named http_proxy has been set does not mean the wiki needs to use it for external HTTP connections.

It might not be useful for the Wiki, but is probably useful for the CLI utilities.

(In reply to comment #4)

It might not be useful for the Wiki, but is probably useful for the CLI
utilities.

(In reply to comment #3)

Suggest WONTFIX. Just because an environment variable named http_proxy has been
set does not mean the wiki needs to use it for external HTTP connections.

This setting (or another one which supplies the proxy address) _is_ needed for the curl call (side-upload of a file = upload a file by its URL) when proxy settings are needed for the server where the mediawiki lives. See inside http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/HttpFunctions.php?view=markup