Page MenuHomePhabricator

Tabbing from the editor should go to the edit summary field
Closed, ResolvedPublic

Description

In the normal textarea, pressing Tab will move the cursor to the edit summary field. Using the WikiEditor editor, it goes to the next focusable element, which in most cases (including the MediaWiki default) is a link to the copyright page.

Tabbing should go from the Wikieditor to the edit summary field.

Tested r61651 on Firefox 3.5.6 on Fedora 11


Version: unspecified
Severity: trivial

Details

Reference
bz22311

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:58 PM
bzimport set Reference to bz22311.

Should be trivial: setting the tabindex on the <iframe> equal to the one on the <textarea> should do it.

See r62022 for a tabindex fix in core.

  • Bug 22396 has been marked as a duplicate of this bug. ***
  • Bug 22397 has been marked as a duplicate of this bug. ***

(In reply to comment #2)

See r62022 for a tabindex fix in core.

This "fix" doesn't do anything (see CR) and is unrelated to this bug.

(In reply to comment #4)

  • Bug 22397 has been marked as a duplicate of this bug. ***

This report mentioned that tabbing back (Shift+Tab) from the iframe should go to the section title box on section=new . This is also due to the lack of a tabindex attribute.

amiller1 wrote:

Added a tabindex to the iframe in r62127 in hopes for addressing this concern.

  • Bug 22417 has been marked as a duplicate of this bug. ***
  • Bug 22438 has been marked as a duplicate of this bug. ***

(In reply to comment #8)

  • Bug 22438 has been marked as a duplicate of this bug. ***

Per this report Chrome inserts a literal tab character when Tab is pressed.

wikibugs wrote:

Wiki_bug_2010-02-09_22311.pdf

The tab is not pointing to Edit summary on Chrome 4 and Safari 5 browsers.

Attached:

amiller1 wrote:

Assuming you meant Safari 4.

You may have been viewing old code on prototype. It's working for me right now in Safari 4 and Chrome 4. Please check it out again.

(In reply to comment #11)
Indeed, after emptying the cache, it works correctly now on Wikipedia under Chrome.

(In reply to comment #12)

(In reply to comment #11)
Indeed, after emptying the cache, it works correctly now on Wikipedia under
Chrome.

The fix was deployed a few hours ago, thanks for confirming.