hook SpecialRecentChangesQuery should pass $query_options ; and respect return value
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Wikinaut
	Jan 29 2010, 8:10 AM

Description

diff patch

In SpecialRecentChangesQuery function doMainQuery hook parameters should also pass $query_options to enable external modification such as 'group by rc_namespace, rc_title'

wfRunHooks('SpecialRecentChangesQuery', array( &$conds, &$tables, &$join_conds, $opts ) );

==>

wfRunHooks('SpecialRecentChangesQuery', array( &$conds, &$tables, &$join_conds, $opts, &$query_options ) );

The hook call lacks also checking the return value (a false return value should skip/abort further processing in case the extension took over processing).

Version: 1.16.x
Severity: normal
URL: http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/specials/SpecialRecentchanges.php?view=markup&sortby=date&pathrev=61652

attachment x.diff ignored as obsolete

Details

Reference: bz22315

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:59 PM

• bzimport added a project: MediaWiki-Recent-changes.

• bzimport set Reference to bz22315.

• bzimport added a subscriber: Unknown Object (MLST).

Wikinaut created this task.Jan 29 2010, 8:10 AM

Created attachment 7048
diff patch

Attached:

x.diff721 BDownload

Fixed in r61670.

danke

hook SpecialRecentChangesQuery should pass $query_options ; and respect return valueClosed, ResolvedPublicActions

Description

Details

Event Timeline

hook SpecialRecentChangesQuery should pass $query_options ; and respect return value
Closed, ResolvedPublic
Actions