$wgUseExternalEditor prevents reuploading
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• bzimport
	Feb 2 2010, 11:53 PM

Description

Author: bugzilla

Description:
If the Setting $wgUseExternalEditor = false is ion effect, no link to reupload a picture or file is present.

Cause:
In ImagePage.php l.606:

if( $wgUseExternalEditor && $this->img->exists() ) {
 $this->uploadLinksBox();
}

Fix:

if( $this->img->exists() ) {
 $this->uploadLinksBox();
}

AND surround l.573-584 with an if:

if( $wgUseExternalEditor  ) {
 $elink = $sk->link(
			$this->mTitle,
			wfMsgHtml( 'edit-externally' ),
			array(),
			array(
				'action' => 'edit',
				'externaledit' => 'true',
				'mode' => 'file'
			),
			array( 'known', 'noclasses' )
		);
		$wgOut->addHTML( '<li id="mw-imagepage-edit-external">' . $elink . ' <small>' . wfMsgExt( 'edit-externally-help', array( 'parseinline' ) ) . "</small></li>\n" );
}