Page MenuHomePhabricator

Text orientation for Arabic link dialogue is reversed
Closed, ResolvedPublic

Description

Author: nkomura

Description:
The text, "Target page or URL:" and "Page does not exist" in Arabic prototype is displayed LTR instead of RTL.

FF3 on Ubuntu 9.04
As of 2:49am February 3 (UTC)


Version: unspecified
Severity: normal
URL: http://prototype.wikimedia.org/ar-wp/index.php?&title=%D8%A7%D9%84%D8%B5%D9%81%D8%AD%D8%A9_%D8%A7%D9%84%D8%B1%D8%A6%D9%8A%D8%B3%D9%8A%D8%A9&action=edit

Details

Reference
bz22367

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:49 PM
bzimport set Reference to bz22367.

nkomura wrote:

Text orientation for RTL link dialogue

Attached:

RTL_Link_Dialogue_Text_Orientation.png (748×1 px, 109 KB)

(In reply to comment #0)

The text, "Target page or URL:" and "Page does not exist" in Arabic prototype
is displayed LTR instead of RTL.

Additionally, the external link icon should be on the left, as well as the radio buttons at the bottom.

nkomura wrote:

The external link status icon should be on the left side of the text. Can we also implement the eternal link icon with the arrow pointing to upper left instead of upper right?

nkomura wrote:

Example of link icon for RTL languages

Attached:

external_link_icon_for_RTL.png (86×372 px, 6 KB)

amiller1 wrote:

Naoko - The external link icon IS on the left side of the text, and the icon even points to the upper left hand side. Maybe someone fixed this before I saw your comment, but I feel like it functioned this way all along. Maybe take another look and let me know if things still don't seem correct.

nkomura wrote:

external link dialogue still at right hand side and icon is pointing to the right instead of left

Attached:

RTL_external_link_icon.png (379×677 px, 28 KB)

nkomura wrote:

I have attached the current screenshot of the arabic prototype. I still see the problem I described in Comment 4. Will you please update the prototype with the fixes?

amiller1 wrote:

Sorry your second screenshot confused me. I thought you started talking about a separate issue.

We currently render the status icon to the left of the text in LTR languages, which is why I felt it was appropriate to render it on the right for RTL languages, as it is currently on prototype. Everything else is switched, so I'm not sure why you feel that icon needs to remain on the same side.

I will add a flipped version of that icon though, as that isn't currently in place.

nkomura wrote:

Yeah, that makes sense.