Page MenuHomePhabricator

Charinsert / Edittools (the old one) does not work
Closed, ResolvedPublic

Description

Firefox 3.6/Windows 7 on dewiki:

Inserting characters via the (old) Edittools/charinsert extension ([[de:MediaWiki:Onlyifediting.js]] does not longer work after deploying the latest UI changes to dewiki.

This extension is still needed to insert characters/code markup not part of the new Edittoolbar.


Version: unspecified
Severity: major

Details

Reference
bz22393

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 10:51 PM
bzimport set Reference to bz22393.

The same problem existed on the English Wikipedia, where the following fix was deployed as suggested by Trevor.

http://en.wikipedia.org/w/index.php?title=MediaWiki:Edittools.js&curid=17396845&diff=342909291&oldid=340525133

A similar change is probably needed for the German Wikipedia version.

wikibugs wrote:

As per http://www.mediawiki.org/wiki/Extension:CharInsert there should be a setting to be done in LocalSettings.php file. Appreciate if you can let me know whether it's done at the server end.

(In reply to comment #2)

As per http://www.mediawiki.org/wiki/Extension:CharInsert there should be a
setting to be done in LocalSettings.php file. Appreciate if you can let me know
whether it's done at the server end.

That's for installing CharInsert, which happened years ago. The setting that does need to be changed is in MediaWiki:Edittool.js ; this happened on English Wikipedia (and possibly other wikis as well), so you can test there.

(In reply to comment #1)

The same problem existed on the English Wikipedia, where the following fix was
deployed as suggested by Trevor.

http://en.wikipedia.org/w/index.php?title=MediaWiki:Edittools.js&curid=17396845&diff=342909291&oldid=340525133

A similar change is probably needed for the German Wikipedia version.

Above code from enwiki applied on dewiki.

Results:

  • Firefox 3.6 and Opera 10.10: Edittools disappeared
  • Chrom 4.0.249.78: Edittools still there but non-functional.

(In reply to comment #4)

(In reply to comment #1)

The same problem existed on the English Wikipedia, where the following fix was
deployed as suggested by Trevor.

http://en.wikipedia.org/w/index.php?title=MediaWiki:Edittools.js&curid=17396845&diff=342909291&oldid=340525133

A similar change is probably needed for the German Wikipedia version.

Above code from enwiki applied on dewiki.

Results:

  • Firefox 3.6 and Opera 10.10: Edittools disappeared
  • Chrom 4.0.249.78: Edittools still there but non-functional.

That's because you pasted it in the wrong place. The code thedj inserted on enwiki is context-sensitive and can't just be thrown in anywhere.

Because dewiki doesn't override insertTags, it'll have to wait for a similar fix to edit.js to be deployed. This'll hopefully happen today.

wikibugs wrote:

This is not able to verify since the user account do not have sufficient authorization to follow the steps given in http://en.wikipedia.org/wiki/MediaWiki:Edittools.js

(In reply to comment #7)

This is not able to verify since the user account do not have sufficient
authorization to follow the steps given in
http://en.wikipedia.org/wiki/MediaWiki:Edittools.js

You don't need to do any magic there, you can just test whether the feature works or not.

I can confirm it works on ro.wp. I noticed this problem yesterday and I was looking for the bug. :)