| • bzimport | |
| Feb 9 2010, 11:50 AM |
| F6319: DifferenceEngine.php.patch | |
| Nov 21 2014, 10:55 PM |
Author: wikibugs
Description:
Steps to reproduce:
1)Start editing random page
2)Click on show changes button without doing any changes to page
<<Texts called 'Current revision', 'Your text' will display >>
Expected outcome:
Disable the show changes button and enable only if the changes are made to page
or
Display an appropriate message saying 'No changes to display or something like that'
Version: unspecified
Severity: enhancement
This is an enhancement request for MediaWiki in general, not specific to the UsabilityInitiative extension.
emo-name wrote:
Added message when no changes founded
I've add message "No change was made to the text" ('diff-nochanges' in Messages*.php file) when nothing changed
For 1.16 version DifferenceInterface.php should be patched insted of DifferenceEngine.php
Attached:
(In reply to comment #2)
For 1.16 version DifferenceInterface.php should be patched insted of
DifferenceEngine.php
This is not a high priority feature or bug, I'm not sure we should patch 1.16 at all or 1.17 for that matter. HEAD is 1.18 right now.
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
sumanah wrote:
Elancev Michael, thank you for the patch, and sorry it's taken so long to get a response! Adding the "need-review" keyword to signal that developers should review it.
sumanah wrote:
Elancev Michael:
Thanks again for the patch. My apologies on the wait for a response. Are you interested in updating it, and using developer access to directly suggest it into our Git source control system? That would get a faster review.
https://www.mediawiki.org/wiki/Developer_access
https://www.mediawiki.org/wiki/Git/Workflow#How_to_submit_a_patch
rd232 wrote:
(In reply to comment #7)
I'm not sure what this bug is actually supposed to ask; compare bug 14431.
The patch seems to be the answer to bug 14431 (show a suitable message when "show changes" button is clicked and there aren't any changes). By contrast, THIS bug is asking for the "show changes" button not to be shown in the first place when there aren't any changes. This presumably requires clientside logic, not serverside.