Page MenuHomePhabricator

Slightly improve native player of FF/Chrome
Closed, ResolvedPublic

Description

remove width setting on div surrounding player and options.

The native a/v players of FireFox and Chrome, have a minimum width that is rather larger. Many times Wikipedia requests players sizes that are much more slim. This creates problems when users of those browsers visit these pages. The player far extends outside the thumb or template box (See Template:Listen). mwEmbed solves this with a 'custom' player, but there is a quick fix for most usecases.

The div around the player has a fixed width at all times. This fixed width is not really needed. In thumb mode, it is not needed at all, because the thumb box already has a fixed width, and in noicon mode (the most used mode for audio/video) there is no need for a width restriction.

I propose the attached patch, which removes the width property. This has no effect for thumb modes, while solving the issue of the native players in noicon mode.

Tested with native mode, QT and Cortado.


Version: unspecified
Severity: enhancement

Attached:

Details

Reference
bz22538

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:59 PM
bzimport set Reference to bz22538.

ayg wrote:

I wasn't able to test this, since I can't get Ogg uploads working locally. It seems to be a reasonable change in principle, though . . .