Page MenuHomePhabricator

wgAjaxWatch.setLinkText doesn't work in Vector if icon mode is not used
Closed, DeclinedPublic

Description

If I use the Vector skin and change (by user JS) the class of the element with ID "ca-watch" or "ca-unwatch", the text of the Watch/Unwatch link doesn't change when I click on it.

I think this is because Vector has additional <span> around the link text and because of this, wgAjaxWatch.setLinkText doesn't work.


Version: 1.16.x
Severity: minor

Details

Reference
bz22556

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:01 PM
bzimport set Reference to bz22556.
bzimport added a subscriber: Unknown Object (MLST).

You need to make a special case for the condition that the text is surrounded by a span, as this span is required so that we can make this work on all browsers. Such accommodations have already been made in scripts that add/change tabs and drop-down menus in Vector.

wgAjaxWatch has been deprecated and removed for a while now.