Page MenuHomePhabricator
Create Task
Maniphest T24559

wikidiff2 is extremely slow with tall/vertical input
Closed, DeclinedPublic
Actions

Description

more vertical markup input is, longer it takes for wkidiff2 to compare it.

e.g. ~160kb text file, when presented in vertical form of 30k lines, it took 40s to compare changes, whereas same text file when reformatted into 2k lines, was compared in 0.027s.

Version: unspecified
Severity: enhancement

Details

Reference
bz22559

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:01 PM
• bzimport added projects: wikidiff2, Performance Issue.
• bzimport set Reference to bz22559.
• bzimport added a subscriber: Unknown Object (MLST).
Domas created this task.Feb 17 2010, 1:42 AM
• tstarling added a comment.Feb 17 2010, 3:08 AM

Please attach test files.

Domas added a comment.Feb 17 2010, 11:29 AM

testcase

Hereby I attach an archive with files:

a1, a2 - expensive delta
b1, b2 - cheap delta

Attached:

bug22559-testcases.tar.gz198 KBDownload

Nemo_bis added a comment.Apr 13 2012, 8:22 AM

Reality check for severity -> enhancement (also compare other bugs in wikidiff2).

Domas added a comment.Apr 14 2012, 1:15 AM

yup, screw perf.

• RobLa-WMF added a comment.Nov 1 2012, 12:36 AM

Adding performance keyword, but removing Tim specifically since he's not working on this one right now.

Krinkle renamed this task from extremely poor performance with vertical files to wikidiff2 is extremely slow with tall/vertical input.Jun 6 2020, 12:11 AM
Krinkle edited projects, added Platform Engineering; removed Performance Issue.
Krinkle removed a subscriber: • wikibugs-l-list.
Krinkle subscribed.

I vaguely recall this having been improved some years ago. Tagging CPT to confirm.

Krinkle added a project: Performance-Team (Radar).Jun 6 2020, 12:12 AM
Krinkle added a subscriber: • tstarling.
• eprodromou removed a project: Platform Engineering.Jun 9 2020, 8:08 PM
• eprodromou subscribed.

Happy if Tim can give more input for historical purposes, but unless there's been some activity on this ticket in the last 10 years, doesn't seem like something CPT should concentrate on right now. Retag as necessary.

Krinkle closed this task as Declined.Jun 23 2020, 6:23 PM
Krinkle edited projects, added Performance Issue, Platform Engineering; removed Performance-Team (Radar).
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL